[test] Fix failing test_browser in edge #16688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No bundle size changes comparing 95522aa...614bf63 |
eps1lon
force-pushed
the
test/fix-menu-test-edge
branch
from
debcab9
to
614bf63
Compare
eps1lon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16683
Replaces
sinon#useFakeTimerswith async utilities from@testing-library/react.It already timed out just by calling
useFakeTimersin beforeEach and restoring it in afterEach.I suspect it has to do with
performance.nowusage inMenu. It's not as a meaningful of a test as before but it's better than not testing at all. We can't guarentee exact timings in actual applications anyway.