-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Link page layouts to premium themes #16690
[docs] Link page layouts to premium themes #16690
Conversation
Details of bundle changes.Comparing: d0e6458...8a711c2
|
{{"demo": "pages/getting-started/page-layout-examples/PageLayoutExamples.js", "hideHeader": true}} | ||
|
||
If while using these examples you make changes or enhancements that could improve the | ||
developer experience, or you would like to contribute an additional example, | ||
please consider creating a [pull request on GitHub](https://github.com/mui-org/material-ui/pulls). | ||
|
||
So far we have demos for: | ||
|
||
- A dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the motivation for removing those lines? I have added them in order to solve no matches on popular Algolia search queries. For instance, after these changes, the query "dashbard" on Aloglia would yield 0 results.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, okay. It seemed redundant to list the examples right after the displaying the examples. Makes sense now.
@@ -11,19 +11,11 @@ for reuse in other pages. | |||
For multi-part examples, a table in the README at the linked source code location describes | |||
the purpose of each file. | |||
|
|||
> For complete ready-to-go examples with multiple page layouts, check out the [premium themes](https://themes.material-ui.com) section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@mbrookes You will need to rebase your local fork, it won't pass the Edge tests otherwise. |
No description provided.