Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix SEO reported by Ahrefs #16765

Merged
merged 1 commit into from
Jul 28, 2019

Conversation

oliviertassinari
Copy link
Member

We should be close to a 100% score after these changes.

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Jul 26, 2019
@mui-pr-bot
Copy link

Details of bundle changes.

Comparing: cfedbcb...c3c7ed7

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core 0.00% 0.00% 329,029 329,029 90,922 90,922
@material-ui/core/Paper 0.00% 0.00% 68,722 68,722 20,472 20,472
@material-ui/core/Paper.esm 0.00% 0.00% 61,984 61,984 19,222 19,222
@material-ui/core/Popper 0.00% 0.00% 28,960 28,960 10,420 10,420
@material-ui/core/Textarea 0.00% 0.00% 5,541 5,541 2,373 2,373
@material-ui/core/TrapFocus 0.00% 0.00% 3,808 3,808 1,602 1,602
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 16,162 16,162 5,815 5,815
@material-ui/core/useMediaQuery 0.00% 0.00% 3,101 3,101 1,312 1,312
@material-ui/lab 0.00% 0.00% 141,953 141,953 43,911 43,911
@material-ui/styles 0.00% 0.00% 52,124 52,124 15,463 15,463
@material-ui/system 0.00% 0.00% 15,579 15,579 4,431 4,431
Button 0.00% 0.00% 79,740 79,740 24,366 24,366
Modal 0.00% 0.00% 14,632 14,632 5,126 5,126
Portal 0.00% 0.00% 3,484 3,484 1,564 1,564
Rating 0.00% 0.00% 70,491 70,491 22,094 22,094
Slider 0.00% 0.00% 75,323 75,323 23,338 23,338
colorManipulator 0.00% 0.00% 3,904 3,904 1,543 1,543
docs.landing 0.00% 0.00% 52,056 52,056 13,832 13,832
docs.main +0.01% 🔺 +0.01% 🔺 606,828 606,890 194,402 194,415
packages/material-ui/build/umd/material-ui.production.min.js 0.00% 0.00% 301,611 301,611 86,715 86,715

Generated by 🚫 dangerJS against c3c7ed7

- [Table](/api/table)
- [TextField](/api/text-field)
- [Toolbar](/api/toolbar)
- [Button](/api/button/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to lint for these issues? I see this change fairly often. Best with a rationale included which I'm still missing: What is the difference between trailing slash and not? From a server perspective the trailing slash isn't accurate because they don't live in api/button/index.js but api/button.js.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You get the underlying subfolder/index.html vs subfolder.html difference right. It seems to be a legacy issue. Next.js used to add a leading slash automatically, with no way to change it, until v9: vercel/next.js#2944.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the issue is that it creates a 301 without the trailing slash?

If the trailing slash has no other implications we might as well use the default behavior instead.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the issue is the 301 we have right now in production.

What default behavior do you refer to?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What default behavior do you refer to?

The one from next adding trailing slashes to every link.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next doesn't handle markdown.

Copy link
Member Author

@oliviertassinari oliviertassinari Jul 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we are using a custom express server now, we could make the dev env have trailing slashs, to behave like production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants