-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Fix SEO reported by Ahrefs #16765
Conversation
Details of bundle changes.Comparing: cfedbcb...c3c7ed7
|
- [Table](/api/table) | ||
- [TextField](/api/text-field) | ||
- [Toolbar](/api/toolbar) | ||
- [Button](/api/button/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to lint for these issues? I see this change fairly often. Best with a rationale included which I'm still missing: What is the difference between trailing slash and not? From a server perspective the trailing slash isn't accurate because they don't live in api/button/index.js but api/button.js.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You get the underlying subfolder/index.html vs subfolder.html difference right. It seems to be a legacy issue. Next.js used to add a leading slash automatically, with no way to change it, until v9: vercel/next.js#2944.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the issue is that it creates a 301 without the trailing slash?
If the trailing slash has no other implications we might as well use the default behavior instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the issue is the 301 we have right now in production.
What default behavior do you refer to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What default behavior do you refer to?
The one from next adding trailing slashes to every link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Next doesn't handle markdown.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we are using a custom express server now, we could make the dev env have trailing slashs, to behave like production.
We should be close to a 100% score after these changes.