Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Fix various a11y issues reported by lighthouse #18146

Merged
merged 4 commits into from
Nov 2, 2019
Merged

[docs] Fix various a11y issues reported by lighthouse #18146

merged 4 commits into from
Nov 2, 2019

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Nov 1, 2019

Common issues:

  • using a Popper for something that isn't a tooltip without removing the tooltip role by using <Popper role={undefined} />
  • pointing to generic containers in aria-controls
  • missing accessible names (it's less about having those in the docs but more about teaching how these would be set in production)

@eps1lon eps1lon added docs Improvements or additions to the documentation accessibility a11y labels Nov 1, 2019
@mui-pr-bot
Copy link

No bundle size changes comparing 9d0caa5...e4791f1

Generated by 🚫 dangerJS against e4791f1

@eps1lon eps1lon marked this pull request as ready for review November 1, 2019 19:25
@eps1lon eps1lon merged commit f23c7a9 into mui:master Nov 2, 2019
@eps1lon eps1lon deleted the docs/lightouse-audit-a11y branch November 2, 2019 10:37
@snyk-bot snyk-bot mentioned this pull request Jan 7, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
accessibility a11y docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eps1lon @mui-pr-bot @oliviertassinari