-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Run the TypeScript version only #18358
[docs] Run the TypeScript version only #18358
Conversation
7e74e78
to
5105013
Compare
Details of bundle changes.Comparing: d9ce3b9...8a92ab1
|
1948488
to
03b1475
Compare
This forces docs contributions to use typescript. We are not there yet. If anything we should only run js. Hot reloading for TS is already possible |
What's the issue with forcing TypeScript? It seems that most of the valuable contributions comes from developers that know TypeScript. Also, I believe that new contributors could still write JavaScript in the |
In any case, my main interest was to get the Netlify build working to measure the performance impact. If we move forward or not would be a next step to consider after we get the results. I'm trying to get a sense on what's the biggest bottleneck in performance and so we can have a better idea of what we should prioritize. (my second suspect is markdown). |
ea09e5b
to
b207383
Compare
b207383
to
f224cfc
Compare
The performance impact doesn't seem very significant. |
c74704f
to
10a4779
Compare
10a4779
to
8a92ab1
Compare
The markdown comment doesn't seem to have a significant impact either. |
Every time this topic comes up I have to push back against this and get upvoted by people who contribute the most to this repository. The type story for react can be very frustrating which I can navigate because I'm familiar with almost every issue by now. I would not want anybody to waste a single second on an issue that can be solved with We can start this discussion again in a few weeks if you want but so far we've always settled on "don't migrate to TS yet". It seems reopening this issue without any change in the TS infra will result in the same conclusion. |
I'm sorry, I don't have the whole context. I don't understand the problems it would create. My incentive is to put structures in place that help to have a great TypeScript support. From your perspective, what's the main issue with such change? Thank you! |
Based on this comment: #18337 (comment).
Aim to improve Google performance metrics: