-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Upgrade to next 9 #18441
[docs] Upgrade to next 9 #18441
Conversation
Details of bundle changes.Comparing: 05c992e...67d1327
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Early overview while it's still in draft. Feel free to ignore it.
9a884c7
to
fad482d
Compare
f3bf5a0
to
0a143b9
Compare
@@ -84,7 +83,7 @@ | |||
"marked": "^0.8.0", | |||
"material-table": "^1.50.0", | |||
"material-ui-popup-state": "^1.4.1", | |||
"next": "8.1.0", | |||
"next": "9.1.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrade to latest stable next release in a follow-up since they changed how they polyfill.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only issue I can spot on the live preview is the open side nav on the home page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we try to deploy the branch in production to see how that goes before merging?
Right forgot about that one. Will fix.
Not sure what you mean by production. It's already built for the production environment in the deploy previews. |
Awesome, great work!
I had http://material-ui.com/ in mind. So I can run SEO crawlers and tests the locales (e.g. /zh/) |
Why can't you do that with the deploy preview? |
2e342d3
to
67d1327
Compare
@eps1lon I have rebased to resolve the conflict with master, I hope it's fine with you. I think that it's good to land, feel free to merge when you are ready 🚀😄. |
Let's see if this works. |
Preview: https://deploy-preview-18441--material-ui.netlify.com/
/api
moves to/api-docs
to not be considered an API route. Via rewrites we keep the URLs/static
is deprecated in favor of/public
We can use this to move the
/cdn
into/public
. I didn't touch the static paths since this affects some 300 files some of which are translated.Container
is deprecated so I removed itFuture work
investigate if we can remove the custom server.js by using rewrites for i18nDone