[misc] Batch small changes #19012
Merged
[misc] Batch small changes #19012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrookes
added
the
umbrella
|
No bundle size changes comparing a5a7bdb...8eef1be |
|
The change related to #14021 seems ambitious. The width looks off if you have a scrollbar. I might be better as a standalone pull request, I'm not sure there is a quick win potential.
|
This reverts commit a9fcb29.
oliviertassinari
approved these changes
Dec 29, 2019
This was referenced Feb 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have followed (at least) the PR section of the contributing guide.
[docs] Fix mini draw width: a9fcb29[Typography] Improve component prop description: ba936de
[docs] Fix theme explorer query-string typo: 5cab340
[docs] arial-label -> aria-label: f14781e
[docs] Autocomplete typo & grammar: ae87f6a
Regarding a9fcb29, the list item icons used to have 24px padding at desktop widths, and 16px on small screens, so lined up nicely under the nave draw hamburger icon:
https://v1.material-ui.com/demos/drawers/#mini-variant-drawer
At some point the padding was changed to 16px to match the revised spec, but the mini variant drawer width was unchanged, so the icons were no longer centered:
This commit changes the width of the mini-drawer:
But I think a case could be made for reverting the padding change and using 24px on larger screens.