-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Slider] Add a custom scale support #19158
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: aa61ced...8e3ea3e
|
This comment has been minimized.
This comment has been minimized.
oliviertassinari
added
component: slider
This is the name of the generic UI component, not the React module!
new feature
New feature or request
labels
Jan 10, 2020
oliviertassinari
changed the title
[Slider] Feat: add a scale prop to Slider
[Slider] Add a custom scale support
Jan 10, 2020
oliviertassinari
approved these changes
Jan 17, 2020
oliviertassinari
force-pushed
the
feat/SliderScaleProp
branch
from
January 17, 2020 14:29
cf4818e
to
fb7339e
Compare
Thanks @oliviertassinari for create the demo, I was so busy on work that I couldn't do. |
This was referenced Mar 20, 2020
This was referenced Apr 6, 2020
This was referenced Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: slider
This is the name of the generic UI component, not the React module!
new feature
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16574
This pr adds a scale prop to Slider.