[core] Ignore a few flaky visual tests #19226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No bundle size changes comparing e4f33b7...854bf88 |
|
I would just mock images entirely. Our docs should include dimensions for |
|
I'm not sure how it would be implemented. Is it OK if we solve the problem later on? Is this something you want to address? We have a limited number of cases. |
Can be solved later. |
This was referenced Mar 20, 2020
This was referenced Apr 6, 2020
This was referenced Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Waiting to see if we have more…
I have introduced them in #19175. Oops.
Ignoring these tests is a cheap and easy way out. We could imagine better approaches. For instance, wait for them to load (I have seen Happo do it). However, we have a few random images (using Unsplash API). In which cases, we could add a global class name to have them hidden.
In any case, we have them documented, so we can come back to it later (invest more time) if it proves to be an issue.
Actually, I think that if we had to invest more time on the topic, it would be great to throw if an entry in the blacklist isn't used. It would help with future demo refactorizations.