-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Use button in backdrop demo #19282
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the button to open a backdrop uses raw html. This change will make the button use a primary Material UI button.
No bundle size changes comparing 2373c22...4ef8dc5 |
Switched single quotes to double quotes
IDK why I'm not passing so maybe its this
Now typescript file is updated with the javascript one
oliviertassinari
changed the title
Button using Material UI
[docs] Use button in backdrop demo
Jan 18, 2020
oliviertassinari
added
docs
Improvements or additions to the documentation
PR: ready to ship
labels
Jan 18, 2020
oliviertassinari
approved these changes
Jan 18, 2020
@theswerd It's a great first pull request on Material-UI 👌🏻. Thank you for working on it! |
This was referenced Mar 20, 2020
This was referenced Apr 6, 2020
This was referenced Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the button to open a backdrop uses raw html. This change will make the button use a primary Material UI button.