[docs] Improve the demos copy experience #19291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: d30e6bb...efd72a9
|
oliviertassinari
changed the title
oliviertassinari
changed the title
mbrookes
previously requested changes
Jan 19, 2020
|
Got it! I’m away from my computer right now but I will make the changes
later today.
…On Sun, Jan 19, 2020 at 12:19 PM Matt ***@***.***> wrote:
***@***.**** requested changes on this pull request.
You can make "view on GitHub" a menu item, and put copy in its place.
------------------------------
In docs/src/modules/components/Demo.js
<#19291 (comment)>:
> @@ -225,6 +241,8 @@ function Demo(props) {
const handleClickCopy = async () => {
try {
await copy(demoData.raw);
+ setSnackBarMessage('The code has been copied!');
Could you add the strings to the English version of the translations
somewhere in this part of the file:
https://github.com/mui-org/material-ui/blob/master/docs/translations/translations.json#L69
(The rest of the files will be handled by Crowdin).
(Pedantic aside: I don't think we need the "!", it isn't that exciting. 🙂
)
------------------------------
In docs/src/modules/components/Demo.js
<#19291 (comment)>:
> @@ -168,6 +170,20 @@ function Demo(props) {
setDemoHovered(event.type === 'mouseenter');
};
+ const [SnackbarOpen, setSnackbarOpen] = React.useState(false);
+ const [SnackBarMessage, setSnackBarMessage] = React.useState(undefined);
+
+ const Alert = SnackBarProps => {
+ return <MuiAlert elevation={6} variant="filled" {...SnackBarProps} />;
So long as Material-UI remains "Material Design first", I think we should
stick to the non-customized Snackbar.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#19291>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJEI4PXETSNEPU45XQQ2JYLQ6SYT7ANCNFSM4KIWMVHA>
.
|
oliviertassinari
requested changes
Jan 19, 2020
There was a problem hiding this comment.
What about we swap the position of the GitHub and Copy links in this pull request? #19099
| @@ -17,7 +17,7 @@ const useStyles = makeStyles((theme: Theme) => | |||
| }), | |||
| ); | |||
|
|
|||
| export default function ActionAlerts() { | |||
| export default function TransitionAlerts() { | |||
oliviertassinari
added
the
PR: needs revision
oliviertassinari
added
PR: needs revision
oliviertassinari
approved these changes
Jan 20, 2020
oliviertassinari
removed
the
PR: needs revision
Now when the transition alert is open, it offers to close it, and when it is closed it offers to re-open it.
yarn prettier
Snackbar is now fully finished! When someone copies text it willl show them a snackbar to let them know it has been copied!
Got rid of bad code
oliviertassinari
force-pushed
the
Transition-Alert-Interaction
branch
4 times, most recently
from
4937dac
to
7a50c48
Compare
mbrookes
added
the
PR: out-of-date
mbrookes
approved these changes
Jan 20, 2020
oliviertassinari
force-pushed
the
Transition-Alert-Interaction
branch
from
fd51f03
to
7a50c48
Compare
oliviertassinari
removed
the
PR: out-of-date
oliviertassinari
force-pushed
the
Transition-Alert-Interaction
branch
from
7a50c48
to
efd72a9
Compare
|
@theswerd Thank you for leading this effort 👌 |
This was referenced Mar 20, 2020
This was referenced Apr 6, 2020
This was referenced Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #19112
This pr makes a Snackbar show whenever a use copies code or links to the code.
Edit @eps1lon:
Preview