Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ButtonBase] Fix potential memory leak for multi-touch devices #19333

Merged
merged 2 commits into from
Jan 21, 2020

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Jan 21, 2020

Discovered during work on #19332. I originally thought this wasn't a valid sequence anyway but on any multi-touch devices you could fire multiple touchstart before a touchend. The touchend as well as unmounting only cleanup a single timer from touchstart. The other ones are effectively orphaned.

@eps1lon eps1lon added bug 🐛 Something doesn't work component: ButtonBase The React component. labels Jan 21, 2020
@mui-pr-bot
Copy link

Details of bundle changes.

Comparing: a9a5f9f...7a350fd

bundle Size Change Size Gzip Change Gzip
docs.main ▲ +18 B (0.00% ) 596 kB ▲ +4 B (0.00% ) 194 kB
Checkbox ▲ +18 B (+0.02% ) 83.2 kB ▲ +3 B (+0.01% ) 26.3 kB
Tabs ▲ +18 B (+0.02% ) 85.8 kB ▲ +3 B (+0.01% ) 27.2 kB
@material-ui/core[umd] ▲ +18 B (+0.01% ) 318 kB ▲ +2 B (0.00% ) 92 kB
SpeedDial ▲ +18 B (+0.02% ) 86.4 kB ▲ +2 B (+0.01% ) 27.2 kB
TablePagination ▲ +18 B (+0.01% ) 144 kB ▼ -2 B (-0.00% ) 42 kB
@material-ui/core ▲ +18 B (0.00% ) 361 kB ▼ -1 B (-0.00% ) 98.8 kB
Alert ▲ +18 B (+0.02% ) 84 kB ▲ +1 B (0.00% ) 26.3 kB
Autocomplete ▲ +18 B (+0.01% ) 132 kB ▲ +1 B (0.00% ) 41.3 kB
Button ▲ +18 B (+0.02% ) 79.9 kB ▲ +1 B (0.00% ) 24.5 kB
ButtonGroup ▲ +18 B (+0.02% ) 83.4 kB ▲ +1 B (0.00% ) 25.5 kB
Chip ▲ +18 B (+0.02% ) 82.8 kB ▲ +1 B (0.00% ) 25.4 kB
ExpansionPanelSummary ▲ +18 B (+0.02% ) 78.3 kB ▲ +1 B (0.00% ) 24.7 kB
Fab ▲ +18 B (+0.02% ) 77 kB ▲ +1 B (0.00% ) 24 kB
IconButton ▲ +18 B (+0.02% ) 76.3 kB ▲ +1 B (0.00% ) 23.8 kB
ListItem ▲ +18 B (+0.02% ) 77.3 kB ▲ +1 B (0.00% ) 24.2 kB
MenuItem ▲ +18 B (+0.02% ) 78.4 kB ▲ +1 B (0.00% ) 24.5 kB
Radio ▲ +18 B (+0.02% ) 84.3 kB ▲ +1 B (0.00% ) 26.6 kB
SpeedDialAction ▲ +18 B (+0.02% ) 119 kB ▲ +1 B (0.00% ) 37.5 kB
Switch ▲ +18 B (+0.02% ) 82.4 kB ▲ +1 B (0.00% ) 26 kB
Tab ▲ +18 B (+0.02% ) 76.6 kB ▲ +1 B (0.00% ) 24.2 kB
@material-ui/lab ▲ +18 B (+0.01% ) 185 kB -- 55.2 kB
BottomNavigationAction ▲ +18 B (+0.02% ) 75.7 kB -- 23.9 kB
ButtonBase ▲ +18 B (+0.02% ) 74.2 kB -- 23.3 kB
CardActionArea ▲ +18 B (+0.02% ) 75.3 kB -- 23.7 kB
StepButton ▲ +18 B (+0.02% ) 82.5 kB -- 26.1 kB
TableSortLabel ▲ +18 B (+0.02% ) 77.6 kB -- 24.4 kB
ToggleButton ▲ +18 B (+0.02% ) 76.3 kB -- 24.2 kB
@material-ui/styles -- 51.2 kB -- 15.4 kB
@material-ui/system -- 14.8 kB -- 4.07 kB
AlertTitle -- 64.3 kB -- 20.2 kB
AppBar -- 64.1 kB -- 20 kB
Avatar -- 65.4 kB -- 20.6 kB
AvatarGroup -- 62.4 kB -- 19.6 kB
Backdrop -- 68 kB -- 21 kB
Badge -- 65.4 kB -- 20.4 kB
BottomNavigation -- 62.5 kB -- 19.6 kB
Box -- 71 kB -- 21.7 kB
Breadcrumbs -- 67.9 kB -- 21.3 kB
Card -- 63 kB -- 19.7 kB
CardActions -- 62.2 kB -- 19.5 kB
CardContent -- 62.1 kB -- 19.4 kB
CardHeader -- 65.2 kB -- 20.5 kB
CardMedia -- 62.5 kB -- 19.7 kB
CircularProgress -- 64.2 kB -- 20.3 kB
ClickAwayListener -- 3.91 kB -- 1.55 kB
Collapse -- 68.2 kB -- 21.1 kB
colorManipulator -- 3.88 kB -- 1.52 kB
Container -- 63.4 kB -- 19.8 kB
CssBaseline -- 57.7 kB -- 18.1 kB
Dialog -- 83.2 kB -- 25.9 kB
DialogActions -- 62.2 kB -- 19.5 kB
DialogContent -- 62.3 kB -- 19.5 kB
DialogContentText -- 64.2 kB -- 20.2 kB
DialogTitle -- 64.4 kB -- 20.2 kB
Divider -- 62.7 kB -- 19.7 kB
docs.landing -- 50.5 kB -- 13.3 kB
Drawer -- 85 kB -- 25.8 kB
ExpansionPanel -- 72.5 kB -- 22.7 kB
ExpansionPanelActions -- 62.2 kB -- 19.5 kB
ExpansionPanelDetails -- 62.1 kB -- 19.4 kB
Fade -- 23.6 kB -- 8 kB
FilledInput -- 73.7 kB -- 22.9 kB
FormControl -- 64.5 kB -- 20.1 kB
FormControlLabel -- 65.6 kB -- 20.6 kB
FormGroup -- 62.1 kB -- 19.5 kB
FormHelperText -- 63.5 kB -- 20 kB
FormLabel -- 63.6 kB -- 19.7 kB
Grid -- 65.2 kB -- 20.4 kB
GridList -- 62.6 kB -- 19.7 kB
GridListTile -- 63.9 kB -- 20 kB
GridListTileBar -- 63.3 kB -- 19.9 kB
Grow -- 24.2 kB -- 8.21 kB
Hidden -- 66.1 kB -- 20.7 kB
Icon -- 62.9 kB -- 19.7 kB
Input -- 72.6 kB -- 22.7 kB
InputAdornment -- 65.2 kB -- 20.5 kB
InputBase -- 70.8 kB -- 22.2 kB
InputLabel -- 65.5 kB -- 20.2 kB
LinearProgress -- 65.4 kB -- 20.5 kB
Link -- 66.7 kB -- 21.1 kB
List -- 62.5 kB -- 19.5 kB
ListItemAvatar -- 62.2 kB -- 19.5 kB
ListItemIcon -- 62.3 kB -- 19.5 kB
ListItemSecondaryAction -- 62.1 kB -- 19.5 kB
ListItemText -- 65.1 kB -- 20.4 kB
ListSubheader -- 62.9 kB -- 19.8 kB
Menu -- 88.9 kB -- 27.4 kB
MenuList -- 66.2 kB -- 20.7 kB
MobileStepper -- 68 kB -- 21.3 kB
Modal -- 14.5 kB -- 5.05 kB
NativeSelect -- 77 kB -- 24.3 kB
NoSsr -- 2.19 kB -- 1.04 kB
OutlinedInput -- 75 kB -- 23.3 kB
Paper -- 62.5 kB -- 19.5 kB
Popover -- 83.3 kB -- 25.8 kB
Popper -- 28.8 kB -- 10.3 kB
Portal -- 2.92 kB -- 1.3 kB
RadioGroup -- 64.6 kB -- 20 kB
Rating -- 70.6 kB -- 22.7 kB
RootRef -- 4.24 kB -- 1.64 kB
Select -- 117 kB -- 34.6 kB
Skeleton -- 63 kB -- 19.9 kB
Slide -- 25.6 kB -- 8.73 kB
Slider -- 76.8 kB -- 24.3 kB
Snackbar -- 75.5 kB -- 23.6 kB
SnackbarContent -- 63.7 kB -- 20.1 kB
SpeedDialIcon -- 64.7 kB -- 20.3 kB
Step -- 62.8 kB -- 19.7 kB
StepConnector -- 62.8 kB -- 19.8 kB
StepContent -- 69.3 kB -- 21.7 kB
StepIcon -- 64.8 kB -- 20.2 kB
StepLabel -- 68.7 kB -- 21.7 kB
Stepper -- 65 kB -- 20.5 kB
styles/createMuiTheme -- 16.6 kB -- 5.83 kB
SvgIcon -- 63.2 kB -- 19.8 kB
SwipeableDrawer -- 92.4 kB -- 28.9 kB
Table -- 62.7 kB -- 19.7 kB
TableBody -- 62.2 kB -- 19.5 kB
TableCell -- 64.2 kB -- 20.2 kB
TableContainer -- 62.1 kB -- 19.4 kB
TableFooter -- 62.2 kB -- 19.5 kB
TableHead -- 62.2 kB -- 19.5 kB
TableRow -- 62.6 kB -- 19.6 kB
TextareaAutosize -- 5.12 kB -- 2.14 kB
TextField -- 126 kB -- 36.6 kB
ToggleButtonGroup -- 63.3 kB -- 19.9 kB
Toolbar -- 62.5 kB -- 19.6 kB
Tooltip -- 102 kB -- 32.3 kB
TreeItem -- 74.1 kB -- 23.5 kB
TreeView -- 66.8 kB -- 21 kB
Typography -- 63.8 kB -- 20 kB
useAutocomplete -- 14.6 kB -- 5.26 kB
useMediaQuery -- 2.51 kB -- 1.06 kB
Zoom -- 23.6 kB -- 8.12 kB

Generated by 🚫 dangerJS against 7a350fd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: ButtonBase The React component.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants