Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[example] Add @types/node dependency #19383

Merged
merged 3 commits into from
Jan 25, 2020
Merged

[example] Add @types/node dependency #19383

merged 3 commits into from
Jan 25, 2020

Conversation

AlexanderVishnevsky
Copy link
Contributor

@AlexanderVishnevsky AlexanderVishnevsky commented Jan 25, 2020 •
edited
Loading

Fail to compile without this dependency

@AlexanderVishnevsky
Add @types/node dependency
db32ec5 
Fail to compile without this dependency
@mui-pr-bot
Copy link

mui-pr-bot commented Jan 25, 2020 •
edited
Loading

No bundle size changes comparing 0ad3b6d...f6306a9

Generated by 🚫 dangerJS against f6306a9

oliviertassinari
oliviertassinari requested changes Jan 25, 2020
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the issue? Why should it be fixed here?

@oliviertassinari oliviertassinari added the PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI label Jan 25, 2020
@oliviertassinari oliviertassinari changed the title Add @types/node dependency [example] Add @types/node dependency Jan 25, 2020
@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation PR: ready to ship and removed PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI labels Jan 25, 2020
oliviertassinari
oliviertassinari approved these changes Jan 25, 2020
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To answer my questions:

  1. Next.js fail:
    Capture d’écran 2020-01-25 à 19 23 08

  2. Next.js document it https://nextjs.org/docs/basic-features/typescript, https://github.com/zeit/next.js/blob/2ff2e9e12c7d5f5b10adf524eefe9a177b2334ae/examples/with-typescript/package.json#L17

@oliviertassinari oliviertassinari merged commit c3883c8 into mui:master Jan 25, 2020
@oliviertassinari
Copy link
Member

@AlexanderVishnevsky It's a great first pull request on Material-UI 👌🏻. Thank you for working on it!

EsoterikStare pushed a commit to EsoterikStare/material-ui that referenced this pull request Feb 13, 2020
@AlexanderVishnevsky @EsoterikStare
[example] Add @types/node dependency (mui#19383)
c10105d
This was referenced Feb 25, 2020
Closed
Merged
Merged
This was referenced Mar 10, 2020
Merged
Merged
Closed
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 22, 2020
Open
This was referenced Apr 16, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexanderVishnevsky @mui-pr-bot @oliviertassinari