-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Refresh the home page #19430
[docs] Refresh the home page #19430
Conversation
Details of bundle changes.Comparing: 5c84559...6ffab39
|
d9cb905
to
168f2fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great so far. A couple of remarks regarding various issues
- move
HomeQuote
intoHomeQuotes
. These are coupled anyway and the folder is already pretty big. I don't think we're still dogmatic about one-component-per-file, are we? - there's too much unused space on the "first page". If we tighten the red circles slightly we should be able to make install and getting started visible on the landing page:
- link the tweets. Does not have to actually embedd them. But I don't know these people. I should be able to find out more about the quotes with a single click.
I had the same thought, it will be awesome once we have this 💯:+1:. |
Thanks for the initial review.
You're right, I can't see it mattering for internal docs component, so I've merged them as suggested; but it sounds like there may also be an opportunity to introduce a hierarchy to the modules folder, rather than depending on a file naming convention in a flat directory structure.
That's a difficult balancing act. White-space is a good thing in design, and the large top and bottom margin help keep the white-space proportional to a wide left and right margin. That said, there may be some scope to trim it down a bit. Another possibility is finding a new home for the GitHub and Twitter counters, and possibly also "quickWord", which have always seemed a bit lost in their current position. Perhaps the footer would be better suited for the counters at least.
The Twitter examples in the Trello card were 50:50 (for a very small sample size). I wasn't sure if users would care that much when browsing the homepage. There is also an argument that sending first time visitors to your home page off to a source of distraction is not a good idea. I've added links in any case so that we can judge the tradeoff. |
About the tweets: About whitespace:
Definitely. It is already at point where I feel like we have too much files in the same folder. Since the two mentioned files were relatively small, it seemed like the better idea to squash them (should be around 700 lines) instead of introducing hierarchy. |
Sounds like we're on the same page (pun intended 😉)
Same on my MBP. I hope the subtle adjustment strikes a good balance?
Agreed. Let's park that for a follow-up PR – I have merged the two related components into one file in any case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The random+event on the quotes display is pretty smart! I love the changes :)
Co-Authored-By: Olivier Tassinari <olivier.tassinari@gmail.com>
Co-Authored-By: Olivier Tassinari <olivier.tassinari@gmail.com>
I have followed (at least) the PR section of the contributing guide.
Move themes to its own section
Clean up the sponsors section
Testimonial section
New user logos