-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Autocomplete] Should not fire change until IME is confirmed #19499
Merged
oliviertassinari
merged 2 commits into
mui:master
from
teramotodaiki:autocomplete-wait-until-ime-settled
Feb 1, 2020
Merged
[Autocomplete] Should not fire change until IME is confirmed #19499
oliviertassinari
merged 2 commits into
mui:master
from
teramotodaiki:autocomplete-wait-until-ime-settled
Feb 1, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: ac5c1ae...bf38327
|
oliviertassinari
added
the
component: autocomplete
This is the name of the generic UI component, not the React module!
label
Jan 31, 2020
oliviertassinari
changed the title
[Autocomplete] should not fire change event until the IME is confirmed
[Autocomplete] Should not fire change until IME is confirmed
Jan 31, 2020
oliviertassinari
approved these changes
Jan 31, 2020
@teramotodaiki It's a great first pull request on Material-UI 👌🏻. Thank you for working on it! |
EsoterikStare
pushed a commit
to EsoterikStare/material-ui
that referenced
this pull request
Feb 13, 2020
This was referenced Mar 10, 2020
This was referenced Apr 16, 2020
2 tasks
Open
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug 🐛
Something doesn't work
component: autocomplete
This is the name of the generic UI component, not the React module!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19435
Wait confirmation until the IME is settled. As far as I have tried on my PC, This fix works fine on macOS/Chrome, Safari, Firefox and Windows10/Chrome.
We can't test the various IME actually, so I wrote test code assuming Safari, which has the most inscrutable behavior.