-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TextField] Fix label notch for custom htmlFontSize #19558
[TextField] Fix label notch for custom htmlFontSize #19558
Conversation
@kusmierz Do you have a reproduction? |
Details of bundle changes.Comparing: 1a949cd...3e09dfc
|
@oliviertassinari - https://codesandbox.io/s/material-demo-qmvfd I discovered, the issue is caused by custom |
hm, but this is not a good solution either :( see https://www.argos-ci.com/mui-org/material-ui/builds/61163 |
@kusmierz Awesome, thank you for the reproduction. Well, basically, we are in this case: #19409 (review). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I think that it's a good step forward like this. The label is meant to overlap with the input, it's more coherent to use the same font typography.
Another good step forward :). |
It fixes #19409 PR, which introduced another bug with label notch.