Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Refactor EnchancedTable demo #19560

Merged
merged 4 commits into from
Feb 4, 2020
Merged

[docs] Refactor EnchancedTable demo #19560

merged 4 commits into from
Feb 4, 2020

Conversation

ahmad-reza619
Copy link
Contributor

This PR resolve #19363
I have pretty much followed the suggestion written in the issue.

@mui-pr-bot
Copy link

mui-pr-bot commented Feb 4, 2020

No bundle size changes comparing 1a949cd...290f8c6

Generated by 🚫 dangerJS against 290f8c6

@ahmad-reza619 ahmad-reza619 changed the title Refactor docs enchanced table demo [Docs] Refactor EnchancedTable demo Feb 4, 2020
Copy link

@MareoRaft MareoRaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good!

Possible Todo: check to see if similar sorting examples exist somewhere in the repo

Possible Todo: verify the code example(s) still works

@MareoRaft
Copy link

Okay, I did a search and I didn't find getSorting anywhere else in the repo. So todo 1 is satisfied. I don't think todo 2 is a requirement. You are free to move forward at your discretion. Thanks and good luck!

@oliviertassinari oliviertassinari changed the title [Docs] Refactor EnchancedTable demo [socs] Refactor EnchancedTable demo Feb 4, 2020
@oliviertassinari oliviertassinari changed the title [socs] Refactor EnchancedTable demo [docs] Refactor EnchancedTable demo Feb 4, 2020
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Feb 4, 2020
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Improve EnhancedTable demo
5 participants