-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add post-update to examples so they run on CodeSandbox #19605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Importing this example to CodeSandbox doesn't work, but it does with this.
Importing this example to CodeSandbox doesn't work, but it does with this.
Added in error - not required as it's a client sandbox, not container.
Added in error - not required as it's a client sandbox, not container.
oliviertassinari
changed the title
Adding post-update to examples so they run on CodeSandbox
[docs] Add post-update to examples so they run on CodeSandbox
Feb 7, 2020
oliviertassinari
approved these changes
Feb 7, 2020
No bundle size changes comparing 0db2675...dd0c5fc |
Thank you! |
EsoterikStare
pushed a commit
to EsoterikStare/material-ui
that referenced
this pull request
Feb 13, 2020
This was referenced Mar 10, 2020
This was referenced Mar 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per @oliviertassinari's suggestion at codesandbox/codesandbox-client#2284 (comment), I've added post-updates to each of the container sandbox example package.json files so they run on CodeSandbox without issue.