-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Autocomplete] Make options required #19648
Merged
oliviertassinari
merged 2 commits into
mui:master
from
alexandesigner:fix/autocomplete-return-empty-array
Feb 11, 2020
Merged
[Autocomplete] Make options required #19648
oliviertassinari
merged 2 commits into
mui:master
from
alexandesigner:fix/autocomplete-return-empty-array
Feb 11, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: e534b94...4c6eb23
|
@alexandesigner Thanks for the pull request, I think that this is a concern bigger than the Autocomplete. Let's wait the resolution of this discussion before moving forward :) #19647 (comment) |
oliviertassinari
changed the title
[Autocomplete] fix: Creating another check if options is null returns an empty array
[Autocomplete] Make options requured
Feb 10, 2020
oliviertassinari
changed the title
[Autocomplete] Make options requured
[Autocomplete] Make options required
Feb 10, 2020
oliviertassinari
added
component: autocomplete
This is the name of the generic UI component, not the React module!
new feature
New feature or request
labels
Feb 10, 2020
oliviertassinari
force-pushed
the
fix/autocomplete-return-empty-array
branch
from
February 10, 2020 19:45
462c184
to
4c6eb23
Compare
oliviertassinari
approved these changes
Feb 10, 2020
EsoterikStare
pushed a commit
to EsoterikStare/material-ui
that referenced
this pull request
Feb 13, 2020
This was referenced Mar 10, 2020
This was referenced Mar 21, 2020
This was referenced Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
component: autocomplete
This is the name of the generic UI component, not the React module!
new feature
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
This PR fix the bug I reported on that issue #19647
Closes #19647
Edit @eps1lon: