Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Encourage mui-rff #19676

Merged
merged 2 commits into from
Feb 13, 2020
Merged

[docs] Encourage mui-rff #19676

merged 2 commits into from
Feb 13, 2020

Conversation

lookfirst
Copy link
Contributor

link the form libraries. shorter and more consistent description text.

link the form libraries. shorter and more consistent description text.
@mui-pr-bot
Copy link

mui-pr-bot commented Feb 12, 2020

No bundle size changes comparing b841933...8869ced

Generated by 🚫 dangerJS against 8869ced

Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pushing the final form integration further :)

@lookfirst
Copy link
Contributor Author

Looks like the test failures are unrelated.

.................................12 02 2020 19:21:12.003:ERROR [launcher.browserstack]: Can not start Chrome 49.0 (OS X Sierra)
  Error: Validation Failed - `device` required
12 02 2020 19:21:12.011:ERROR [launcher.browserstack]: Can not start Edge 14.0 (Windows 10)
  Error: Validation Failed - `device` required
................................12 02 2020 19:21:12.064:ERROR [launcher.browserstack]: Can not start Firefox 52.0 (Windows 10)
  Error: Validation Failed - `device` required

@oliviertassinari oliviertassinari changed the title [docs] remove link to unmaintained react-final-form project [docs] Remove link to unmaintained react-final-form project Feb 12, 2020
@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation PR: ready to ship labels Feb 12, 2020
@lookfirst
Copy link
Contributor Author

@oliviertassinari It would be nice to somehow promote these utilities in places other than just at the bottom of a single form component page. Copy/paste to the other form components feels weird.

The lack of a single page with a demo of many form components has also identified some weirdness in how they interact together (like defaulting to the non-default margin="normal" to get proper spacing).

Also, most of my traffic is from the MUI site, so getting more eyes would be nice. Suggestions?

@oliviertassinari
Copy link
Member

oliviertassinari commented Feb 12, 2020

We have forgotten about /docs/src/pages/components/text-fields/text-fields.md

@lookfirst
Copy link
Contributor Author

Forgotten?

@oliviertassinari oliviertassinari changed the title [docs] Remove link to unmaintained react-final-form project [docs] Encourage mui-rff Feb 13, 2020
@oliviertassinari oliviertassinari merged commit e41ecf0 into mui:master Feb 13, 2020
@oliviertassinari
Copy link
Member

Oops, my bad, it was the related projects that was forgotten, fixed, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants