Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AvatarGroup] Add max avatar prop #19853

Merged
merged 7 commits into from
Mar 16, 2020
Merged

[AvatarGroup] Add max avatar prop #19853

merged 7 commits into from
Mar 16, 2020

Conversation

GFynbo
Copy link
Contributor

@GFynbo GFynbo commented Feb 26, 2020 •
edited
Loading

This adds the max avatars displayed prop to the AvatarGroup for automatically adding an avatar with +x functionality. The default value is 5 and can be overridden with max=x. The docs and examples have been updated.

References #18869

@GFynbo
Copy link
Contributor Author

GFynbo commented Feb 26, 2020

@oliviertassinari Can you take a look at this when you get a chance?

@mui-pr-bot
Copy link

mui-pr-bot commented Feb 26, 2020 •
edited
Loading

@material-ui/lab: parsed: +1.01% , gzip: +1.05%

Details of bundle changes.

Comparing: f27c78f...69f9942

Details of page changes
bundle Size Change Size Gzip Change Gzip
docs:chunks/19d5847e1647a271a7b77be135532553ef1444d4.e4fec7.js ▼ -14.9 kB (-100.00% ) 0 B ▲ +1 B (-100.00% ) 0 B
docs:chunks/948b34b5e0f309b98efe5701292a429ab1796455.e4fec7.js ▲ +14.9 kB (+Infinity% ) 14.9 kB ▼ -1 B (-Infinity% ) -1 B
docs:chunks/acc9374d17db092612ba6f4de47958fe40214b57.3bbb15.js ▼ -14.3 kB (-100.00% ) 0 B ▲ +1 B (-100.00% ) 0 B
docs:chunks/e5b03a2fdceb944432d273cc3ff5c0f94c95f424.3bbb15.js ▲ +14.3 kB (+Infinity% ) 14.3 kB ▼ -1 B (-Infinity% ) -1 B
docs:chunks/18b92cf00c8cddc49082c2883a15dfbc4029cbfa.25a992.js ▲ +13.9 kB (+Infinity% ) 13.9 kB ▼ -1 B (-Infinity% ) -1 B
docs:chunks/47f7bce7de8adace9d0892d899a69216a7aae402.25a992.js ▼ -13.9 kB (-100.00% ) 0 B ▲ +1 B (-100.00% ) 0 B
docs:chunks/7ce3a8de3a1eb901afc8e3f8aea90a585d9f9765.c16f0a.js ▼ -8.22 kB (-100.00% ) 0 B ▲ +1 B (-100.00% ) 0 B
docs:chunks/e25c30fc71c962e7f573bbf6cd598c5cbd73f068.c16f0a.js ▲ +8.22 kB (+Infinity% ) 8.22 kB ▼ -1 B (-Infinity% ) -1 B
docs:chunks/46999a4d0d4e2a8c599884dce7c77641bc4f750d.f1aa72.js ▼ -7.32 kB (-100.00% ) 0 B ▲ +1 B (-100.00% ) 0 B
docs:chunks/982f96e03c35bc2e634cb48151d8f4b596e6b027.f1aa72.js ▲ +7.32 kB (+Infinity% ) 7.32 kB ▼ -1 B (-Infinity% ) -1 B
docs:chunks/0082aa40a53afe7fd31c9ce1c9ac52fedb75de31.832236.js ▼ -5.74 kB (-100.00% ) 0 B ▲ +1 B (-100.00% ) 0 B
docs:chunks/7a66adc9002c23baf0a6354fff5d9cf74a4bf7a4.832236.js ▲ +5.74 kB (+Infinity% ) 5.74 kB ▼ -1 B (-Infinity% ) -1 B
docs:chunks/2c65f1b20b2e10d03253704d19afc3c18abf9b47.d0a0b7.js ▼ -2.81 kB (-100.00% ) 0 B ▲ +1 B (-100.00% ) 0 B
docs:chunks/91c3231e05aa5f705967fb8e2f4b20f1dc77bc10.d0a0b7.js ▲ +2.81 kB (+Infinity% ) 2.81 kB ▼ -1 B (-Infinity% ) -1 B
docs:runtime/webpack.080314.js ▼ -1.24 kB (-100.00% ) 0 B ▲ +1 B (-100.00% ) 0 B
docs:runtime/webpack.8535ec.js ▲ +1.24 kB (+Infinity% ) 1.24 kB ▼ -1 B (-Infinity% ) -1 B
/api-docs/avatar-group ▲ +30 B (+2.44% ) 1.26 kB -- -1 B
/components/avatars ▲ +20 B (+0.24% ) 8.5 kB -- -1 B
/performance/table-emotion ▼ -10 B (-0.34% ) 2.96 kB -- -1 B
/_app -- 33.9 kB -- -1 B
/api-docs/alert-title -- 1.12 kB -- -1 B
/api-docs/alert -- 2.15 kB -- -1 B
/api-docs/app-bar -- 1.69 kB -- -1 B
/api-docs/autocomplete -- 3.89 kB -- -1 B
/api-docs/avatar -- 1.61 kB -- -1 B
/api-docs/backdrop -- 1.38 kB -- -1 B
/api-docs/badge -- 1.88 kB -- -1 B
/api-docs/bottom-navigation-action -- 1.55 kB -- -1 B
/api-docs/bottom-navigation -- 1.43 kB -- -1 B
/api-docs/breadcrumbs -- 1.59 kB -- -1 B
/api-docs/button-base -- 2.08 kB -- -1 B
/api-docs/button-group -- 1.95 kB -- -1 B
/api-docs/button -- 2.32 kB -- -1 B
/api-docs/card-action-area -- 1.32 kB -- -1 B
/api-docs/card-actions -- 1.22 kB -- -1 B
/api-docs/card-content -- 1.2 kB -- -1 B
/api-docs/card-header -- 1.53 kB -- -1 B
/api-docs/card-media -- 1.43 kB -- -1 B
/api-docs/card -- 1.25 kB -- -1 B
/api-docs/checkbox -- 2.05 kB -- -1 B
/api-docs/chip -- 2.19 kB -- -1 B
/api-docs/circular-progress -- 1.8 kB -- -1 B
/api-docs/click-away-listener -- 1.13 kB -- -1 B
/api-docs/collapse -- 1.76 kB -- -1 B
/api-docs/container -- 1.62 kB -- -1 B
/api-docs/css-baseline -- 1.14 kB -- -1 B
/api-docs/dialog-actions -- 1.22 kB -- -1 B
/api-docs/dialog-content-text -- 1.23 kB -- -1 B
/api-docs/dialog-content -- 1.2 kB -- -1 B
/api-docs/dialog-title -- 1.26 kB -- -1 B
/api-docs/dialog -- 2.48 kB -- -1 B
/api-docs/divider -- 1.55 kB -- -1 B
/api-docs/drawer -- 1.87 kB -- -1 B
/api-docs/expansion-panel-actions -- 1.25 kB -- -1 B
/api-docs/expansion-panel-details -- 1.18 kB -- -1 B
/api-docs/expansion-panel-summary -- 1.46 kB -- -1 B
/api-docs/expansion-panel -- 1.7 kB -- -1 B
/api-docs/fab -- 1.86 kB -- -1 B
/api-docs/fade -- 1.17 kB -- -1 B
/api-docs/filled-input -- 2.65 kB -- -1 B
/api-docs/form-control-label -- 1.73 kB -- -1 B
/api-docs/form-control -- 2.1 kB -- -1 B
/api-docs/form-group -- 1.3 kB -- -1 B
/api-docs/form-helper-text -- 1.66 kB -- -1 B
/api-docs/form-label -- 1.59 kB -- -1 B
/api-docs/grid-list-tile-bar -- 1.54 kB -- -1 B
/api-docs/grid-list-tile -- 1.46 kB -- -1 B
/api-docs/grid-list -- 1.37 kB -- -1 B
/api-docs/grid -- 2.29 kB -- -1 B
/api-docs/grow -- 1.23 kB -- -1 B
/api-docs/hidden -- 1.32 kB -- -1 B
/api-docs/icon-button -- 1.85 kB -- -1 B
/api-docs/icon -- 1.54 kB -- -1 B
/api-docs/input-adornment -- 1.68 kB -- -1 B
/api-docs/input-base -- 2.74 kB -- -1 B
/api-docs/input-label -- 1.82 kB -- -1 B
/api-docs/input -- 2.61 kB -- -1 B
/api-docs/linear-progress -- 1.78 kB -- -1 B
/api-docs/link -- 1.68 kB -- -1 B
/api-docs/list-item-avatar -- 1.25 kB -- -1 B
/api-docs/list-item-icon -- 1.27 kB -- -1 B
/api-docs/list-item-secondary-action -- 1.22 kB -- -1 B
/api-docs/list-item-text -- 1.54 kB -- -1 B
/api-docs/list-item -- 2 kB -- -1 B
/api-docs/list-subheader -- 1.51 kB -- -1 B
/api-docs/list -- 1.44 kB -- -1 B
/api-docs/menu-item -- 1.46 kB -- -1 B
/api-docs/menu-list -- 1.33 kB -- -1 B
/api-docs/menu -- 2.12 kB -- -1 B
/api-docs/mobile-stepper -- 1.67 kB -- -1 B
/api-docs/modal -- 2.14 kB -- -1 B
/api-docs/native-select -- 1.83 kB -- -1 B
/api-docs/no-ssr -- 1.09 kB -- -1 B
/api-docs/outlined-input -- 2.76 kB -- -1 B
/api-docs/pagination-item -- 1.71 kB -- -1 B
/api-docs/pagination -- 1.98 kB -- -1 B
/api-docs/paper -- 1.61 kB -- -1 B
/api-docs/popover -- 2.5 kB -- -1 B
/api-docs/popper -- 1.76 kB -- -1 B
/api-docs/portal -- 1.12 kB -- -1 B
/api-docs/radio-group -- 1.2 kB -- -1 B
/api-docs/radio -- 1.89 kB -- -1 B
/api-docs/rating -- 2.25 kB -- -1 B
/api-docs/root-ref -- 1.2 kB -- -1 B
/api-docs/scoped-css-baseline -- 1.15 kB -- -1 B
/api-docs/select -- 2.65 kB -- -1 B
/api-docs/skeleton -- 1.52 kB -- -1 B
/api-docs/slide -- 1.31 kB -- -1 B
/api-docs/slider -- 2.85 kB -- -1 B
/api-docs/snackbar-content -- 1.36 kB -- -1 B
/api-docs/snackbar -- 2.46 kB -- -1 B
/api-docs/speed-dial-action -- 1.67 kB -- -1 B
/api-docs/speed-dial-icon -- 1.29 kB -- -1 B
/api-docs/speed-dial -- 2.05 kB -- -1 B
/api-docs/step-button -- 1.38 kB -- -1 B
/api-docs/step-connector -- 1.29 kB -- -1 B
/api-docs/step-content -- 1.47 kB -- -1 B
/api-docs/step-icon -- 1.33 kB -- -1 B
/api-docs/step-label -- 1.64 kB -- -1 B
/api-docs/step -- 1.38 kB -- -1 B
/api-docs/stepper -- 1.6 kB -- -1 B
/api-docs/svg-icon -- 2.01 kB -- -1 B
/api-docs/swipeable-drawer -- 1.78 kB -- -1 B
/api-docs/switch -- 2.19 kB -- -1 B
/api-docs/tab -- 1.74 kB -- -1 B
/api-docs/table-body -- 1.21 kB -- -1 B
/api-docs/table-cell -- 1.87 kB -- -1 B
/api-docs/table-container -- 1.22 kB -- -1 B
/api-docs/table-footer -- 1.22 kB -- -1 B
/api-docs/table-head -- 1.21 kB -- -1 B
/api-docs/table-pagination -- 2.21 kB -- -1 B
/api-docs/table-row -- 1.43 kB -- -1 B
/api-docs/table-sort-label -- 1.57 kB -- -1 B
/api-docs/table -- 1.43 kB -- -1 B
/api-docs/tabs -- 2.28 kB -- -1 B
/api-docs/text-field -- 2.94 kB -- -1 B
/api-docs/textarea-autosize -- 908 B -- -1 B
/api-docs/toggle-button-group -- 1.56 kB -- -1 B
/api-docs/toggle-button -- 1.55 kB -- -1 B
/api-docs/toolbar -- 1.4 kB -- -1 B
/api-docs/tooltip -- 2.3 kB -- -1 B
/api-docs/tree-item -- 1.53 kB -- -1 B
/api-docs/tree-view -- 1.67 kB -- -1 B
/api-docs/typography -- 2.33 kB -- -1 B
/api-docs/zoom -- 1.19 kB -- -1 B
/blog/2019-developer-survey-results -- 5.94 kB -- -1 B
/blog/2019 -- 3.82 kB -- -1 B
/blog/april-2019-update -- 2.71 kB -- -1 B
/blog/august-2019-update -- 1.82 kB -- -1 B
/blog/december-2019-update -- 1.96 kB -- -1 B
/blog/july-2019-update -- 1.71 kB -- -1 B
/blog/june-2019-update -- 1.58 kB -- -1 B
/blog/march-2019-update -- 2.12 kB -- -1 B
/blog/material-ui-v1-is-out -- 6.25 kB -- -1 B
/blog/material-ui-v4-is-out -- 9.28 kB -- -1 B
/blog/may-2019-update -- 1.91 kB -- -1 B
/blog/november-2019-update -- 2.32 kB -- -1 B
/blog/october-2019-update -- 2.06 kB -- -1 B
/blog/september-2019-update -- 2.25 kB -- -1 B
/company/about -- 1.51 kB -- -1 B
/company/contact -- 1.1 kB -- -1 B
/company/jobs -- 1.11 kB -- -1 B
/company/software-engineer -- 5.03 kB -- -1 B
/components/about-the-lab -- 3.19 kB -- -1 B
/components/alert -- 11.1 kB -- -1 B
/components/app-bar -- 30.9 kB -- -1 B
/components/autocomplete -- 106 kB -- -1 B
/components/backdrop -- 3.51 kB -- -1 B
/components/badges -- 14.2 kB -- -1 B
/components/bottom-navigation -- 6.22 kB -- -1 B
/components/box -- 7.96 kB -- -1 B
/components/breadcrumbs -- 14.4 kB -- -1 B
/components/button-group -- 6.56 kB -- -1 B
/components/buttons -- 17.6 kB -- -1 B
/components/cards -- 16.8 kB -- -1 B
/components/checkboxes -- 16.9 kB -- -1 B
/components/chips -- 21.6 kB -- -1 B
/components/click-away-listener -- 3.39 kB -- -1 B
/components/container -- 3.6 kB -- -1 B
/components/css-baseline -- 5.86 kB -- -1 B
/components/dialogs -- 42.1 kB -- -1 B
/components/dividers -- 12.1 kB -- -1 B
/components/drawers -- 30.3 kB -- -1 B
/components/expansion-panels -- 20.1 kB -- -1 B
/components/floating-action-button -- 10.2 kB -- -1 B
/components/grid-list -- 11.9 kB -- -1 B
/components/grid -- 33.4 kB -- -1 B
/components/hidden -- 10.5 kB -- -1 B
/components/icons -- 22.3 kB -- -1 B
/components/links -- 6.83 kB -- -1 B
/components/lists -- 33 kB -- -1 B
/components/material-icons -- 708 kB -- -1 B
/components/menus -- 23.3 kB -- -1 B
/components/modal -- 11.5 kB -- -1 B
/components/no-ssr -- 5.02 kB -- -1 B
/components/pagination -- 6.75 kB -- -1 B
/components/paper -- 3.34 kB -- -1 B
/components/pickers -- 38.1 kB -- -1 B
/components/popover -- 14.7 kB -- -1 B
/components/popper -- 22.5 kB -- -1 B
/components/portal -- 3.29 kB -- -1 B
/components/progress -- 21.8 kB -- -1 B
/components/radio-buttons -- 15.5 kB -- -1 B
/components/rating -- 10.7 kB -- -1 B
/components/selects -- 25.3 kB -- -1 B
/components/skeleton -- 10.1 kB -- -1 B
/components/slider -- 14.5 kB -- -1 B
/components/snackbars -- 24.8 kB -- -1 B
/components/speed-dial -- 14.6 kB -- -1 B
/components/steppers -- 35.9 kB -- -1 B
/components/switches -- 16.5 kB -- -1 B
/components/tables -- 176 kB -- -1 B
/components/tabs -- 19.3 kB -- -1 B
/components/text-fields -- 53 kB -- -1 B
/components/textarea-autosize -- 2.81 kB -- -1 B
/components/toggle-button -- 10.5 kB -- -1 B
/components/tooltips -- 17.3 kB -- -1 B
/components/transfer-list -- 9.3 kB -- -1 B
/components/transitions -- 10.8 kB -- -1 B
/components/tree-view -- 11.1 kB -- -1 B
/components/typography -- 9.67 kB -- -1 B
/components/use-media-query -- 13.1 kB -- -1 B
/customization/breakpoints -- 15.2 kB -- -1 B
/customization/color -- 21.6 kB -- -1 B
/customization/components -- 37.9 kB -- -1 B
/customization/default-theme -- 7.99 kB -- -1 B
/customization/density -- 9.16 kB -- -1 B
/customization/globals -- 4.65 kB -- -1 B
/customization/palette -- 11.8 kB -- -1 B
/customization/spacing -- 2.51 kB -- -1 B
/customization/theming -- 17.4 kB -- -1 B
/customization/typography -- 10.9 kB -- -1 B
/customization/z-index -- 3.03 kB -- -1 B
/discover-more/backers -- 2.89 kB -- -1 B
/discover-more/changelog -- 1.37 kB -- -1 B
/discover-more/languages -- 3.32 kB -- -1 B
/discover-more/related-projects -- 6.02 kB -- -1 B
/discover-more/roadmap -- 3.67 kB -- -1 B
/discover-more/showcase -- 13.3 kB -- -1 B
/discover-more/team -- 6.5 kB -- -1 B
/discover-more/vision -- 7.03 kB -- -1 B
/getting-started/example-projects -- 6.17 kB -- -1 B
/getting-started/faq -- 31.8 kB -- -1 B
/getting-started/installation -- 7.05 kB -- -1 B
/getting-started/learn -- 7.88 kB -- -1 B
/getting-started/support -- 9.7 kB -- -1 B
/getting-started/supported-components -- 6.19 kB -- -1 B
/getting-started/supported-platforms -- 5.69 kB -- -1 B
/getting-started/templates -- 8.1 kB -- -1 B
/getting-started/templates/album -- 5.66 kB -- -1 B
/getting-started/templates/blog -- 7.42 kB -- -1 B
/getting-started/templates/checkout -- 11.2 kB -- -1 B
/getting-started/templates/dashboard -- 8.56 kB -- -1 B
/getting-started/templates/pricing -- 7.86 kB -- -1 B
/getting-started/templates/sign-in-side -- 9.31 kB -- -1 B
/getting-started/templates/sign-in -- 9.54 kB -- -1 B
/getting-started/templates/sign-up -- 9.65 kB -- -1 B
/getting-started/templates/sticky-footer -- 1.54 kB -- -1 B
/getting-started/usage -- 9.37 kB -- -1 B
/guides/api -- 17.4 kB -- -1 B
/guides/composition -- 14 kB -- -1 B
/guides/flow -- 2.21 kB -- -1 B
/guides/interoperability -- 10.8 kB -- -1 B
/guides/localization -- 19.7 kB -- -1 B
/guides/migration-v0x -- 7.23 kB -- -1 B
/guides/migration-v3 -- 20.8 kB -- -1 B
/guides/minimizing-bundle-size -- 8.86 kB -- -1 B
/guides/responsive-ui -- 4.16 kB -- -1 B
/guides/right-to-left -- 6.7 kB -- -1 B
/guides/server-rendering -- 8.38 kB -- -1 B
/guides/testing -- 8.33 kB -- -1 B
/guides/typescript -- 12.8 kB -- -1 B
/performance/table-component -- 1.44 kB -- -1 B
/performance/table-hook -- 2.22 kB -- -1 B
/performance/table-mui -- 4.34 kB -- -1 B
/performance/table-raw -- 613 B -- -1 B
/performance/table-styled-components -- 2.61 kB -- -1 B
/premium-themes/onepirate -- 7.11 kB -- -1 B
/premium-themes/onepirate/forgot-password -- 1.01 kB -- -1 B
/premium-themes/onepirate/privacy -- 4.44 kB -- -1 B
/premium-themes/onepirate/sign-in -- 1.07 kB -- -1 B
/premium-themes/onepirate/sign-up -- 1.12 kB -- -1 B
/premium-themes/onepirate/terms -- 11.8 kB -- -1 B
/premium-themes/paperbase -- 8.73 kB -- -1 B
/styles/advanced -- 30.2 kB -- -1 B
/styles/api -- 16 kB -- -1 B
/styles/basics -- 17.2 kB -- -1 B
/system/api -- 5.85 kB -- -1 B
/system/basics -- 25.2 kB -- -1 B
/system/borders -- 4.04 kB -- -1 B
/system/display -- 6.2 kB -- -1 B
/system/flexbox -- 5.71 kB -- -1 B
/system/palette -- 4.28 kB -- -1 B
/system/positions -- 2.46 kB -- -1 B
/system/shadows -- 3.44 kB -- -1 B
/system/sizing -- 3.34 kB -- -1 B
/system/spacing -- 6.05 kB -- -1 B
/system/typography -- 4.22 kB -- -1 B
/versions -- 22.7 kB -- -1 B
docs:chunks/commons.5243ee.js -- 5.99 kB -- -1 B
docs:chunks/framework.460644.js -- 42.3 kB -- -1 B
docs:runtime/main.1f9dd2.js -- 6.88 kB -- -1 B
bundle Size Change Size Gzip Change Gzip
AvatarGroup ▲ +3.82 kB (+5.81% ) 69.5 kB ▲ +1.41 kB (+6.86% ) 22 kB
@material-ui/lab ▲ +2 kB (+1.01% ) 201 kB ▲ +621 B (+1.05% ) 59.6 kB
Avatar ▼ -35 B (-0.05% ) 68.5 kB ▼ -250 B (-1.15% ) 21.4 kB
Pagination ▲ +2 B (0.00% ) 87.6 kB ▼ -2 B (-0.01% ) 27 kB
Button ▲ +2 B (0.00% ) 83 kB ▼ -1 B (-0.00% ) 25.4 kB
FormHelperText ▲ +2 B (0.00% ) 66.7 kB ▲ +1 B (0.00% ) 20.7 kB
MenuItem ▲ +2 B (0.00% ) 81.4 kB ▲ +1 B (0.00% ) 25.4 kB
Autocomplete ▲ +2 B (0.00% ) 135 kB -- 42.2 kB
Chip ▲ +2 B (0.00% ) 85.9 kB -- 26.3 kB
InputLabel ▲ +2 B (0.00% ) 68.6 kB -- 21.2 kB
LinearProgress ▲ +2 B (0.00% ) 68.7 kB -- 21.2 kB
PaginationItem ▲ +2 B (0.00% ) 84 kB -- 25.9 kB
RadioGroup ▲ +2 B (0.00% ) 67.1 kB -- 20.8 kB
StepLabel ▲ +2 B (0.00% ) 71.9 kB -- 22.2 kB
SvgIcon ▼ -2 B (-0.00% ) 66.4 kB -- 20.7 kB
Tooltip ▲ +2 B (0.00% ) 105 kB -- 33.1 kB
Paper ▲ +1 B (0.00% ) 65.7 kB ▲ +2 B (+0.01% ) 20.5 kB
ButtonBase ▲ +1 B (0.00% ) 77.3 kB ▲ +1 B (0.00% ) 24.2 kB
Menu ▲ +1 B (0.00% ) 91.8 kB ▼ -1 B (-0.00% ) 28.3 kB
Select ▲ +1 B (0.00% ) 119 kB ▲ +1 B (0.00% ) 35.3 kB
TextField ▲ +1 B (0.00% ) 127 kB ▼ -1 B (-0.00% ) 37.3 kB
Drawer ▲ +1 B (0.00% ) 87.9 kB -- 26.8 kB
@material-ui/core -- 360 kB ▲ +8 B (+0.01% ) 98.8 kB
StepButton -- 85.5 kB ▲ +6 B (+0.02% ) 27 kB
BottomNavigationAction -- 78.8 kB ▲ +5 B (+0.02% ) 24.9 kB
Skeleton -- 66.3 kB ▼ -5 B (-0.02% ) 20.9 kB
Alert -- 86.6 kB ▲ +4 B (+0.01% ) 27.3 kB
SpeedDialAction -- 121 kB ▲ +4 B (+0.01% ) 38.4 kB
TableHead -- 65.5 kB ▼ -4 B (-0.02% ) 20.4 kB
Checkbox -- 85.4 kB ▲ +3 B (+0.01% ) 27 kB
CircularProgress -- 67.5 kB ▼ -3 B (-0.01% ) 21.2 kB
DialogContent -- 65.6 kB ▼ -3 B (-0.01% ) 20.5 kB
ExpansionPanelSummary -- 81.4 kB ▲ +3 B (+0.01% ) 25.7 kB
FormControlLabel -- 68.8 kB ▼ -3 B (-0.01% ) 21.6 kB
Grid -- 68.5 kB ▲ +3 B (+0.01% ) 21.4 kB
ListItemSecondaryAction -- 65.4 kB ▼ -3 B (-0.01% ) 20.4 kB
SpeedDial -- 89.4 kB ▲ +3 B (+0.01% ) 28.3 kB
Tab -- 79.6 kB ▲ +3 B (+0.01% ) 25.3 kB
Toolbar -- 65.7 kB ▲ +3 B (+0.01% ) 20.6 kB
TreeItem -- 78.5 kB ▼ -3 B (-0.01% ) 24.8 kB
BottomNavigation -- 65.8 kB ▼ -2 B (-0.01% ) 20.6 kB
Breadcrumbs -- 83.6 kB ▲ +2 B (+0.01% ) 26.5 kB
ButtonGroup -- 86.5 kB ▲ +2 B (+0.01% ) 26.6 kB
CardActionArea -- 78.4 kB ▲ +2 B (+0.01% ) 24.7 kB
CardActions -- 65.4 kB ▼ -2 B (-0.01% ) 20.5 kB
CardHeader -- 68.4 kB ▲ +2 B (+0.01% ) 21.5 kB
Container -- 66.5 kB ▲ +2 B (+0.01% ) 20.8 kB
Dialog -- 86.2 kB ▲ +2 B (+0.01% ) 26.9 kB
Divider -- 66 kB ▲ +2 B (+0.01% ) 20.7 kB
Hidden -- 69.3 kB ▼ -2 B (-0.01% ) 21.7 kB
ListItemText -- 68.3 kB ▲ +2 B (+0.01% ) 21.5 kB
Radio -- 86.4 kB ▲ +2 B (+0.01% ) 27.3 kB
Snackbar -- 78.6 kB ▼ -2 B (-0.01% ) 24.5 kB
TableBody -- 65.4 kB ▲ +2 B (+0.01% ) 20.5 kB
TableCell -- 67.4 kB ▲ +2 B (+0.01% ) 21.2 kB
TableSortLabel -- 80.6 kB ▲ +2 B (+0.01% ) 25.5 kB
Tabs -- 88.6 kB ▲ +2 B (+0.01% ) 28.3 kB
@material-ui/styles -- 51.4 kB ▼ -1 B (-0.01% ) 15.4 kB
@material-ui/system -- 16.6 kB ▲ +1 B (+0.02% ) 4.31 kB
AlertTitle -- 67.5 kB ▲ +1 B (0.00% ) 21.2 kB
AppBar -- 67.4 kB ▲ +1 B (0.00% ) 21.1 kB
Badge -- 68.7 kB ▲ +1 B (0.00% ) 21.3 kB
Card -- 66.2 kB ▲ +1 B (0.00% ) 20.7 kB
DialogActions -- 65.4 kB ▲ +1 B (0.00% ) 20.5 kB
FormGroup -- 65.4 kB ▲ +1 B (0.00% ) 20.5 kB
GridList -- 65.8 kB ▼ -1 B (-0.00% ) 20.6 kB
GridListTile -- 67.1 kB ▲ +1 B (0.00% ) 21 kB
GridListTileBar -- 66.6 kB ▼ -1 B (-0.00% ) 20.8 kB
Icon -- 66.1 kB ▼ -1 B (-0.00% ) 20.7 kB
IconButton -- 79.4 kB ▲ +1 B (0.00% ) 24.8 kB
InputAdornment -- 68.4 kB ▲ +1 B (0.00% ) 21.5 kB
ListItem -- 80.3 kB ▼ -1 B (-0.00% ) 25.1 kB
ListItemAvatar -- 65.5 kB ▼ -1 B (-0.00% ) 20.5 kB
ListItemIcon -- 65.5 kB ▼ -1 B (-0.00% ) 20.5 kB
ListSubheader -- 66.1 kB ▼ -1 B (-0.00% ) 20.8 kB
MobileStepper -- 71.2 kB ▼ -1 B (-0.00% ) 22.3 kB
RootRef -- 4.21 kB ▲ +1 B (+0.06% ) 1.64 kB
SpeedDialIcon -- 67.9 kB ▲ +1 B (0.00% ) 21.3 kB
Step -- 66 kB ▲ +1 B (0.00% ) 20.7 kB
StepConnector -- 66.1 kB ▼ -1 B (-0.00% ) 20.8 kB
StepContent -- 72.5 kB ▲ +1 B (0.00% ) 22.6 kB
Stepper -- 68.2 kB ▲ +1 B (0.00% ) 21.5 kB
SwipeableDrawer -- 95.3 kB ▲ +1 B (0.00% ) 29.9 kB
Switch -- 84.6 kB ▲ +1 B (0.00% ) 26.5 kB
Table -- 65.9 kB ▼ -1 B (-0.00% ) 20.6 kB
TableContainer -- 65.3 kB ▼ -1 B (-0.00% ) 20.4 kB
TableFooter -- 65.5 kB ▲ +1 B (0.00% ) 20.5 kB
TableRow -- 65.8 kB ▼ -1 B (-0.00% ) 20.6 kB
ToggleButton -- 79.4 kB ▲ +1 B (0.00% ) 25.1 kB
TreeView -- 71.5 kB ▼ -1 B (-0.00% ) 22.4 kB
useAutocomplete -- 15 kB ▲ +1 B (+0.02% ) 5.41 kB
useMediaQuery -- 2.56 kB ▼ -1 B (-0.09% ) 1.06 kB
@material-ui/core[umd] -- 318 kB -- 92.2 kB
Backdrop -- 71.2 kB -- 21.9 kB
Box -- 72.3 kB -- 21.8 kB
CardContent -- 65.3 kB -- 20.4 kB
CardMedia -- 65.7 kB -- 20.6 kB
ClickAwayListener -- 3.84 kB -- 1.54 kB
Collapse -- 71.3 kB -- 22 kB
colorManipulator -- 3.88 kB -- 1.52 kB
CssBaseline -- 65.3 kB -- 20.5 kB
DialogContentText -- 67.4 kB -- 21.1 kB
DialogTitle -- 67.6 kB -- 21.2 kB
docs:/ -- 10.4 kB -- -1 B
docs:/_app -- 33.9 kB -- -1 B
ExpansionPanel -- 74.9 kB -- 23.5 kB
ExpansionPanelActions -- 65.4 kB -- 20.5 kB
ExpansionPanelDetails -- 65.3 kB -- 20.4 kB
Fab -- 80.1 kB -- 24.9 kB
Fade -- 27.1 kB -- 9.04 kB
FilledInput -- 76.9 kB -- 23.9 kB
FormControl -- 67.7 kB -- 21.1 kB
FormLabel -- 66.8 kB -- 20.7 kB
Grow -- 27.7 kB -- 9.25 kB
Input -- 75.9 kB -- 23.7 kB
InputBase -- 74 kB -- 23.2 kB
Link -- 69.9 kB -- 22.1 kB
List -- 65.7 kB -- 20.4 kB
MenuList -- 69.3 kB -- 21.7 kB
Modal -- 14.3 kB -- 5.04 kB
NativeSelect -- 80.1 kB -- 25.3 kB
NoSsr -- 2.17 kB -- 1.03 kB
OutlinedInput -- 77.9 kB -- 24.2 kB
Popover -- 86.3 kB -- 26.7 kB
Popper -- 28.8 kB -- 10.3 kB
Portal -- 2.87 kB -- 1.29 kB
Rating -- 73.8 kB -- 23.7 kB
ScopedCssBaseline -- 66.2 kB -- 20.7 kB
Slide -- 29.1 kB -- 9.78 kB
Slider -- 79.1 kB -- 25.2 kB
SnackbarContent -- 66.9 kB -- 21 kB
StepIcon -- 67.9 kB -- 21.2 kB
styles/createMuiTheme -- 20.9 kB -- 7.27 kB
TablePagination -- 145 kB -- 42.6 kB
TextareaAutosize -- 5.19 kB -- 2.17 kB
ToggleButtonGroup -- 66.5 kB -- 20.9 kB
Typography -- 67 kB -- 20.9 kB
Zoom -- 27.1 kB -- 9.17 kB

Generated by 🚫 dangerJS against 69f9942

@GFynbo GFynbo mentioned this pull request Feb 26, 2020
Closed
2 tasks
@oliviertassinari oliviertassinari changed the title [AvatarGroup] Add max avatar prop to AvatarGroup [AvatarGroup] Add max avatar prop Feb 26, 2020
@oliviertassinari oliviertassinari added component: avatar This is the name of the generic UI component, not the React module! new feature New feature or request labels Feb 26, 2020
oliviertassinari
oliviertassinari previously requested changes Feb 26, 2020
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start. I don't know if we need a standalone demo in the documentation for this feature, but we definitely need a new test.

docs/src/pages/components/avatars/GroupAvatars.tsx Show resolved Hide resolved
packages/material-ui-lab/src/AvatarGroup/AvatarGroup.js Outdated Show resolved Hide resolved
@oliviertassinari oliviertassinari added the PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI label Feb 26, 2020
mbrookes
mbrookes reviewed Feb 26, 2020
View reviewed changes
Copy link
Member

@mbrookes mbrookes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Playing with the prop descriptions. (It might inspire further tweaks. @joshwooding ?)

Also, it would be good to add a demo for the new functionality.

packages/material-ui-lab/src/AvatarGroup/AvatarGroup.js Show resolved Hide resolved
packages/material-ui-lab/src/AvatarGroup/AvatarGroup.js Outdated Show resolved Hide resolved
eps1lon
eps1lon previously requested changes Mar 1, 2020
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there's a lot of room for off-by-one errors we should add some tests for various combinations of children.length and max.

packages/material-ui-lab/src/AvatarGroup/AvatarGroup.js Show resolved Hide resolved
@oliviertassinari
Copy link
Member

@GFynbo Let us know if there is any blockers to complete the pull request :).

@GFynbo
Copy link
Contributor Author

GFynbo commented Mar 11, 2020

@oliviertassinari Yup! Just some personal issues came up so I've been a little behind but will be finishing this up and pushing Friday/Sat. Sorry!

@oliviertassinari oliviertassinari removed the PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI label Mar 15, 2020
@oliviertassinari oliviertassinari dismissed stale reviews from eps1lon and themself March 15, 2020 18:51

updated

@oliviertassinari oliviertassinari force-pushed the issue/18869-max branch 2 times, most recently from a46a63e to d008c8e Compare March 15, 2020 20:52
oliviertassinari
oliviertassinari approved these changes Mar 15, 2020
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GFynbo I have tried to apply the feedback suggested in the review. Let me know if it looks all right :)

@GFynbo
Copy link
Contributor Author

GFynbo commented Mar 16, 2020

@oliviertassinari Looking through it now. Sorry for the delay!! The coronavirus is throwing things off.

@GFynbo
Copy link
Contributor Author

GFynbo commented Mar 16, 2020

@oliviertassinari It looks good to me! Only consideration is to give a different name to the people in the docs example but it doesn't really matter since it's not showing up

@eps1lon eps1lon merged commit 93ef218 into mui:master Mar 16, 2020
@eps1lon
Copy link
Member

eps1lon commented Mar 16, 2020

@GFynbo Nice work!

This was referenced Mar 20, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
EsoterikStare pushed a commit to EsoterikStare/material-ui that referenced this pull request Mar 30, 2020
@GFynbo @EsoterikStare
[AvatarGroup] Add max avatar prop (mui#19853)
7fe7c75
This was referenced Apr 10, 2020
Closed
Merged
Merged
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 19, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request May 4, 2020
Closed
@oliviertassinari oliviertassinari mentioned this pull request Mar 29, 2022
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshwooding joshwooding joshwooding left review comments

@eps1lon eps1lon eps1lon left review comments

@mbrookes mbrookes mbrookes left review comments

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
component: avatar This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@GFynbo @mui-pr-bot @oliviertassinari @eps1lon @mbrookes @joshwooding