-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Autocomplete] Autocomplete popup improvement #19901
Merged
oliviertassinari
merged 5 commits into
mui:master
from
haseebdaone:autocomplete-popup-improvement
Mar 1, 2020
Merged
[Autocomplete] Autocomplete popup improvement #19901
oliviertassinari
merged 5 commits into
mui:master
from
haseebdaone:autocomplete-popup-improvement
Mar 1, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: b9dec27...20b4918
|
oliviertassinari
added
component: autocomplete
This is the name of the generic UI component, not the React module!
new feature
New feature or request
labels
Feb 29, 2020
oliviertassinari
approved these changes
Mar 1, 2020
@haseebdaone Well done, thanks |
This was referenced Mar 20, 2020
So, the Autocomplete no longer opens on focus by default? Was this not a breaking change? |
@zekehernandez Correct, the Autocomplete is in an alpha state, breaking changes are expected between versions. |
Thanks for the quick response! And good to know, thanks. |
EsoterikStare
pushed a commit
to EsoterikStare/material-ui
that referenced
this pull request
Mar 30, 2020
This was referenced Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
component: autocomplete
This is the name of the generic UI component, not the React module!
new feature
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18815
Also I'm not that confident when it comes to testing so there might be room for improvement on this code
Breaking change
Rename the prop
openOnFocus
->disableOpenOnFocus
and make it enabled by default.