Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Autocomplete] Autocomplete popup improvement #19901

Merged

Conversation

haseebdaone
Copy link
Contributor

@haseebdaone haseebdaone commented Feb 29, 2020

Closes #18815

Also I'm not that confident when it comes to testing so there might be room for improvement on this code

Breaking change

Rename the prop openOnFocus -> disableOpenOnFocus and make it enabled by default.

@mui-pr-bot
Copy link

mui-pr-bot commented Feb 29, 2020

Details of bundle changes.

Comparing: b9dec27...20b4918

bundle Size Change Size Gzip Change Gzip
Autocomplete ▼ -229 B (-0.17% ) 132 kB ▼ -71 B (-0.17% ) 41.4 kB
@material-ui/lab ▼ -229 B (-0.12% ) 196 kB ▼ -70 B (-0.12% ) 58.2 kB
useAutocomplete ▼ -219 B (-1.49% ) 14.5 kB ▼ -62 B (-1.16% ) 5.27 kB
OutlinedInput -- 74.9 kB ▲ +5 B (+0.02% ) 23.4 kB
Drawer -- 84.9 kB ▲ +3 B (+0.01% ) 25.9 kB
Modal -- 14.3 kB ▼ -3 B (-0.06% ) 5.03 kB
SwipeableDrawer -- 92.3 kB ▲ +3 B (+0.01% ) 28.9 kB
TextField -- 125 kB ▲ +3 B (+0.01% ) 36.7 kB
@material-ui/core -- 359 kB ▼ -2 B (-0.00% ) 99 kB
Dialog -- 83.2 kB ▼ -2 B (-0.01% ) 25.9 kB
Menu -- 88.8 kB ▲ +2 B (+0.01% ) 27.5 kB
MenuList -- 66.3 kB ▲ +2 B (+0.01% ) 20.8 kB
Popover -- 83.2 kB ▲ +2 B (+0.01% ) 25.8 kB
Select -- 116 kB ▲ +2 B (+0.01% ) 34.7 kB
Snackbar -- 75.6 kB ▼ -2 B (-0.01% ) 23.7 kB
Backdrop -- 68.2 kB ▲ +1 B (0.00% ) 21.1 kB
Fade -- 23.6 kB ▲ +1 B (+0.01% ) 8.01 kB
Grow -- 24.2 kB ▼ -1 B (-0.01% ) 8.22 kB
Hidden -- 66.3 kB ▲ +1 B (0.00% ) 20.8 kB
Slide -- 25.6 kB ▲ +1 B (+0.01% ) 8.74 kB
Slider -- 76.9 kB ▲ +1 B (0.00% ) 24.2 kB
SpeedDialAction -- 119 kB ▲ +1 B (0.00% ) 37.6 kB
TablePagination -- 143 kB ▼ -1 B (-0.00% ) 42 kB
Tabs -- 85.5 kB ▲ +1 B (0.00% ) 27.2 kB
Tooltip -- 102 kB ▲ +1 B (0.00% ) 32.5 kB
@material-ui/core[umd] -- 318 kB -- 92.3 kB
@material-ui/styles -- 51.4 kB -- 15.4 kB
@material-ui/system -- 16.5 kB -- 4.32 kB
Alert -- 83.6 kB -- 26.4 kB
AlertTitle -- 64.5 kB -- 20.3 kB
AppBar -- 64.3 kB -- 20.2 kB
Avatar -- 65.5 kB -- 20.7 kB
AvatarGroup -- 62.7 kB -- 19.7 kB
Badge -- 65.6 kB -- 20.4 kB
BottomNavigation -- 62.7 kB -- 19.7 kB
BottomNavigationAction -- 75.8 kB -- 24 kB
Box -- 72.2 kB -- 21.9 kB
Breadcrumbs -- 80.6 kB -- 25.4 kB
Button -- 80 kB -- 24.6 kB
ButtonBase -- 74.3 kB -- 23.4 kB
ButtonGroup -- 83.4 kB -- 25.6 kB
Card -- 63.2 kB -- 19.8 kB
CardActionArea -- 75.3 kB -- 23.8 kB
CardActions -- 62.4 kB -- 19.6 kB
CardContent -- 62.3 kB -- 19.5 kB
CardHeader -- 65.4 kB -- 20.6 kB
CardMedia -- 62.7 kB -- 19.7 kB
Checkbox -- 83.1 kB -- 26.3 kB
Chip -- 82.8 kB -- 25.4 kB
CircularProgress -- 64.4 kB -- 20.3 kB
ClickAwayListener -- 3.84 kB -- 1.54 kB
Collapse -- 68.3 kB -- 21.2 kB
colorManipulator -- 3.88 kB -- 1.52 kB
Container -- 63.5 kB -- 19.9 kB
CssBaseline -- 62.3 kB -- 19.6 kB
DialogActions -- 62.4 kB -- 19.6 kB
DialogContent -- 62.5 kB -- 19.6 kB
DialogContentText -- 64.4 kB -- 20.2 kB
DialogTitle -- 64.6 kB -- 20.3 kB
Divider -- 63 kB -- 19.8 kB
docs.landing -- 56.6 kB -- 15.6 kB
docs.main -- 601 kB -- 195 kB
ExpansionPanel -- 72.6 kB -- 22.7 kB
ExpansionPanelActions -- 62.4 kB -- 19.6 kB
ExpansionPanelDetails -- 62.3 kB -- 19.5 kB
ExpansionPanelSummary -- 78.3 kB -- 24.8 kB
Fab -- 77.1 kB -- 24.1 kB
FilledInput -- 73.9 kB -- 23 kB
FormControl -- 64.7 kB -- 20.2 kB
FormControlLabel -- 65.8 kB -- 20.7 kB
FormGroup -- 62.3 kB -- 19.5 kB
FormHelperText -- 63.7 kB -- 20 kB
FormLabel -- 63.8 kB -- 19.8 kB
Grid -- 65.4 kB -- 20.5 kB
GridList -- 62.8 kB -- 19.7 kB
GridListTile -- 64 kB -- 20.1 kB
GridListTileBar -- 63.5 kB -- 19.9 kB
Icon -- 63.1 kB -- 19.8 kB
IconButton -- 76.4 kB -- 23.9 kB
Input -- 72.9 kB -- 22.8 kB
InputAdornment -- 65.4 kB -- 20.6 kB
InputBase -- 71 kB -- 22.3 kB
InputLabel -- 65.6 kB -- 20.5 kB
LinearProgress -- 65.6 kB -- 20.5 kB
Link -- 66.9 kB -- 21.1 kB
List -- 62.7 kB -- 19.6 kB
ListItem -- 77.3 kB -- 24.3 kB
ListItemAvatar -- 62.4 kB -- 19.6 kB
ListItemIcon -- 62.5 kB -- 19.6 kB
ListItemSecondaryAction -- 62.3 kB -- 19.5 kB
ListItemText -- 65.3 kB -- 20.5 kB
ListSubheader -- 63.1 kB -- 19.8 kB
MenuItem -- 78.4 kB -- 24.6 kB
MobileStepper -- 68.1 kB -- 21.4 kB
NativeSelect -- 77.1 kB -- 24.4 kB
NoSsr -- 2.17 kB -- 1.03 kB
Pagination -- 85.3 kB -- 26.3 kB
PaginationItem -- 81 kB -- 25 kB
Paper -- 62.7 kB -- 19.6 kB
Popper -- 28.8 kB -- 10.3 kB
Portal -- 2.87 kB -- 1.29 kB
Radio -- 84.1 kB -- 26.6 kB
RadioGroup -- 64.9 kB -- 20.2 kB
Rating -- 70.7 kB -- 22.7 kB
RootRef -- 4.21 kB -- 1.63 kB
ScopedCssBaseline -- 63.1 kB -- 19.9 kB
Skeleton -- 63.3 kB -- 20 kB
SnackbarContent -- 63.8 kB -- 20.1 kB
SpeedDial -- 86.4 kB -- 27.3 kB
SpeedDialIcon -- 64.9 kB -- 20.3 kB
Step -- 63 kB -- 19.8 kB
StepButton -- 82.5 kB -- 26.2 kB
StepConnector -- 63 kB -- 19.8 kB
StepContent -- 69.5 kB -- 21.8 kB
StepIcon -- 64.9 kB -- 20.3 kB
StepLabel -- 68.9 kB -- 21.7 kB
Stepper -- 65.2 kB -- 20.6 kB
styles/createMuiTheme -- 16.6 kB -- 5.85 kB
SvgIcon -- 63.4 kB -- 19.8 kB
Switch -- 82.3 kB -- 26 kB
Tab -- 76.6 kB -- 24.3 kB
Table -- 62.9 kB -- 19.7 kB
TableBody -- 62.4 kB -- 19.5 kB
TableCell -- 64.3 kB -- 20.3 kB
TableContainer -- 62.3 kB -- 19.5 kB
TableFooter -- 62.4 kB -- 19.5 kB
TableHead -- 62.4 kB -- 19.5 kB
TableRow -- 62.8 kB -- 19.7 kB
TableSortLabel -- 77.6 kB -- 24.4 kB
TextareaAutosize -- 5.19 kB -- 2.17 kB
ToggleButton -- 76.4 kB -- 24.2 kB
ToggleButtonGroup -- 63.5 kB -- 20 kB
Toolbar -- 62.7 kB -- 19.7 kB
TreeItem -- 75.5 kB -- 23.9 kB
TreeView -- 69.2 kB -- 21.7 kB
Typography -- 64 kB -- 20 kB
useMediaQuery -- 2.56 kB -- 1.06 kB
Zoom -- 23.6 kB -- 8.13 kB

Generated by 🚫 dangerJS against 20b4918

@oliviertassinari oliviertassinari added component: autocomplete This is the name of the generic UI component, not the React module! new feature New feature or request labels Feb 29, 2020
@oliviertassinari
Copy link
Member

@haseebdaone Well done, thanks

@zekehernandez
Copy link
Contributor

So, the Autocomplete no longer opens on focus by default? Was this not a breaking change?

@oliviertassinari
Copy link
Member

@zekehernandez Correct, the Autocomplete is in an alpha state, breaking changes are expected between versions.

@zekehernandez
Copy link
Contributor

Thanks for the quick response! And good to know, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: autocomplete This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Autocomplete] Improve popup open logic
4 participants