-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Simplify drawer examples #20040
[docs] Simplify drawer examples #20040
Conversation
Details of bundle changes.Comparing: f27c78f...d08d53f Details of page changes
|
@mbrookes @oliviertassinari Any suggestions on how to fix these bugs? |
@oliviertassinari @mbrookes Here is a screen shot of my changes: |
@eps1lon Reverting changes in package.JSON didn't fix the yarn.lock file conflictions. Do you have a suggestion how I might fix them? |
a273031
to
f8979fa
Compare
f8979fa
to
d08d53f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for raising this problem and for giving it shot; I have explored a different path. I have tried to make the "code preview" easier to follow. Let me know if it matches the expectation of the simplification you were going after. Thanks :)
@TommyJackson85 Nice work, thanks! |
@eps1lon Glad to be of some help anyway! @oliviertassinari I can see this has reduced the complication for sure, i.e. you removed the repetition of drawers through the use of the map function. Thanks, its a good best of both worlds! |
STILL IN PROGESS I will keep updating this initial post as it goes
Created a "one side only" version of the Swipeable Drawer for the Drawer documentation. This is for developers to have the option of a simpler code base.
updated the
drawers.md
file to include the demo.Looking for suggestions.
I could also have this PR include a one sided version of the 'regular' (none swipeable) temporary drawer too, as that also has multi sides only.
I intend not to remove the "multi side" version of the Swipeable drawer, as I believe this is useful too for developers, however I am open to further suggestions.
This is the first time doing a big development like this. Please give me as much advice as possible. :)
Closes #20018