-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Select] Simplify the demos (remove ref) #20076
Merged
Merged
+8
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@oliviertassinari
P.S. This comment is not relative to PR |
Details of bundle changes.Comparing: 7102777...6c9231a Details of page changes
|
I'll take a look at the hydration warning. |
eps1lon
previously requested changes
Mar 11, 2020
oliviertassinari
added
component: select
This is the name of the generic UI component, not the React module!
docs
Improvements or additions to the documentation
labels
Mar 12, 2020
oliviertassinari
changed the title
[Select] Docs improvement
[Select] Simplify the demos (remove ref)
Mar 12, 2020
oliviertassinari
approved these changes
Mar 13, 2020
eps1lon
approved these changes
Mar 13, 2020
@captain-yossarian Thank you! |
This was referenced Mar 20, 2020
EsoterikStare
pushed a commit
to EsoterikStare/material-ui
that referenced
this pull request
Mar 30, 2020
This was referenced Apr 10, 2020
This was referenced Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: select
This is the name of the generic UI component, not the React module!
docs
Improvements or additions to the documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19144