-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Update type defs to use OverridableComponent #20110
Merged
eps1lon
merged 3 commits into
mui:master
from
abbasyadollahi:mui-19536-typings-for-custom-component-props
Mar 16, 2020
Merged
[core] Update type defs to use OverridableComponent #20110
eps1lon
merged 3 commits into
mui:master
from
abbasyadollahi:mui-19536-typings-for-custom-component-props
Mar 16, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
approved these changes
Mar 15, 2020
oliviertassinari
changed the title
[core] Update component type defs to use OverrideProps (#19536)
[core] Update type defs to use OverridableComponent
Mar 15, 2020
eps1lon
approved these changes
Mar 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Just had to update the branch to work around https://status.dev.azure.com/_event/179641421
Details of bundle changes.Comparing: bbcc43d...f97352e Details of page changes
|
@theGirrafish Nice work, thanks! |
This was referenced Mar 19, 2020
This was referenced Mar 20, 2020
EsoterikStare
pushed a commit
to EsoterikStare/material-ui
that referenced
this pull request
Mar 30, 2020
This was referenced Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #19536
I had difficulty with the
Paper
component because it uses the base HTMLElement. I tried defaulting the new signature to adiv
tag, although it made the following test fail. I tried looking into and believe it might be related to the PR.