[TreeView] Fix focus steal #20232
Merged
[TreeView] Fix focus steal #20232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: c16f941...c9e2cae Details of page changes
|
oliviertassinari
added
the
component: tree view
eps1lon
reviewed
Mar 22, 2020
|
https://codesandbox.io/s/bold-hill-rw9y5 - sandbox with bug |
oliviertassinari
changed the title
- groups statements into arrange-act-assert - removes indirection in act (a click does what?) - moves from gDSFP to effect during mutation
eps1lon
reviewed
Mar 27, 2020
There was a problem hiding this comment.
Similar approach used as in #20240:
- had a hard time with the click-mounted indirection (what does a click accomplish? why do I need to call it twice?) so I made an explicit state setter. Hope this makes it more clear
- update state when the item is removed not during the render after the item is removed
|
Yes that's better. |
eps1lon
reviewed
Mar 27, 2020
| @@ -56,9 +56,10 @@ const TreeView = React.forwardRef(function TreeView(props, ref) { | |||
| ...other | |||
| } = props; | |||
| const [tabbable, setTabbable] = React.useState(null); | |||
| const [focused, setFocused] = React.useState(null); | |||
| const [focusedNodeId, setFocusedNodeId] = React.useState(null); | |||
There was a problem hiding this comment.
focused implies that this component is focused but it's actually for tracking other components. For example FormControl also has a focused state but that has a different meaning.
|
Confirmed manually that it does indeed fix the crashes in the linked issue. |
|
@tonyhallett Thanks! |
EsoterikStare
pushed a commit
to EsoterikStare/material-ui
that referenced
this pull request
Mar 30, 2020
This was referenced Mar 30, 2020
This was referenced Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19882