-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Fix TablePagination props swap descriptions #20274
Merged
oliviertassinari
merged 1 commit into
mui:master
from
johncalvinroberts:fix-table-pagination-doc
Mar 25, 2020
Merged
[docs] Fix TablePagination props swap descriptions #20274
oliviertassinari
merged 1 commit into
mui:master
from
johncalvinroberts:fix-table-pagination-doc
Mar 25, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
component: table
This is the name of the generic UI component, not the React module!
docs
Improvements or additions to the documentation
labels
Mar 25, 2020
Details of bundle changes.Comparing: a14df63...5980995 Details of page changes
|
oliviertassinari
changed the title
[docs] TablePagination props descriptions
[docs] Fix TablePagination props swap descriptions
Mar 25, 2020
@johncalvinroberts It's a great first pull request on Material-UI 👌🏻. Thank you for working on it! |
EsoterikStare
pushed a commit
to EsoterikStare/material-ui
that referenced
this pull request
Mar 30, 2020
This was referenced Mar 30, 2020
This was referenced Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: table
This is the name of the generic UI component, not the React module!
docs
Improvements or additions to the documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Just noticed the props API for
TablePagination
had an error -- descriptions forlabelDisplayedRows
andlabelRowsPerPage
were swapped. Thanks for the awesome lib xoxo <3