[core] Fix Checkbox and Radio type propType #20293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
docs
eps1lon
commented
Mar 26, 2020
| extends StandardProps< | ||
| SwitchBaseProps, | ||
| CheckboxClassKey, | ||
| 'checkedIcon' | 'color' | 'icon' | 'type' |
There was a problem hiding this comment.
Removes type from TS types (point 2)
eps1lon
commented
Mar 26, 2020
| @@ -18,6 +18,7 @@ export interface SwitchBaseProps | |||
| readOnly?: boolean; | |||
| required?: boolean; | |||
| tabIndex?: number; | |||
| type?: React.InputHTMLAttributes<HTMLInputElement>['type']; | |||
There was a problem hiding this comment.
Fixes type type in SwitchBase (point 1)
Details of bundle changes.Comparing: fb002af...3732e11 Details of page changes
|
oliviertassinari
approved these changes
Mar 26, 2020
EsoterikStare
pushed a commit
to EsoterikStare/material-ui
that referenced
this pull request
Mar 30, 2020
This was referenced Mar 30, 2020
This was referenced Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found these while working on more JSDOC in typescript:
<Radio type="submit" />currently passes because we assume that prop is spread to the IconButton but it is passed to the inputtypebecause it doesn't make any sense to me to write<Radio type="checkbox" />or<Checkbox type="radio" />. I think this is a reasonable restriction on "visuals should follow semantics". I've removed it from the TypeScript types and docs only for the time being as a form of a warning. I don't think we need any runtime behavior for this so that people can still force<Radio type="checkbox" />.