-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Autocomplete] Fix multiselect regression #20315
Merged
oliviertassinari
merged 1 commit into
mui:master
from
oliviertassinari:autocomplete-fix-selection-previous
Mar 29, 2020
Merged
[Autocomplete] Fix multiselect regression #20315
oliviertassinari
merged 1 commit into
mui:master
from
oliviertassinari:autocomplete-fix-selection-previous
Mar 29, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
bug 🐛
Something doesn't work
component: autocomplete
This is the name of the generic UI component, not the React module!
labels
Mar 28, 2020
oliviertassinari
force-pushed
the
autocomplete-fix-selection-previous
branch
from
March 28, 2020 23:44
47a106d
to
0fda717
Compare
Details of bundle changes.Comparing: 403a6df...0fda717 Details of page changes
|
EsoterikStare
pushed a commit
to EsoterikStare/material-ui
that referenced
this pull request
Mar 30, 2020
2 tasks
This was referenced Apr 6, 2020
This was referenced Apr 13, 2020
This comment has been minimized.
This comment has been minimized.
in which version is this fix included? |
@Falkyouall You can search the PR number in https://github.com/mui-org/material-ui/blob/HEAD/CHANGELOG.md. |
again what learned. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug 🐛
Something doesn't work
component: autocomplete
This is the name of the generic UI component, not the React module!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regression is most visible on this demo https://material-ui.com/components/autocomplete/#customized-autocomplete. It originated from #19923.
Closes #20388