-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Chip] Fix input integration #20368
[Chip] Fix input integration #20368
Conversation
Details of bundle changes.Comparing: 151834f...85cb2e3 Details of page changes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The handlers of keyDown
and keyUp
still don't use the same logic. handleKeyUp
checks at first if it needs to call the onKeyUp
prop. handleKeyDown
does not. Wouldn't that create new problems again?
I have tried to call |
0c2efcf
to
81df449
Compare
81df449
to
85cb2e3
Compare
Interesting! I think that the parent handler should be called at the end. This way, the parents can access the processed event (with the default prevented). I don't think that it's something we do write in all our components yet :/. |
@chaudharykiran Let us know what you think of the solution I have proposed. I have underestimated the complexity of the problem in the initially proposed patch. Thanks for exploring it! |
Closes #20297