-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Introduce unstable_useId hook #20407
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NMinhNguyen
commented
Apr 5, 2020
NMinhNguyen
commented
Apr 5, 2020
Details of bundle changes.Comparing: 797e738...98c4795 Details of page changes
|
NMinhNguyen
commented
Apr 5, 2020
NMinhNguyen
commented
Apr 6, 2020
eps1lon
reviewed
Apr 6, 2020
oliviertassinari
approved these changes
Apr 6, 2020
eps1lon
reviewed
Apr 7, 2020
joshwooding
reviewed
Apr 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick question - probably obvious
@NMinhNguyen Thanks |
Adding facebook/react#17322 to the thread as it might be relevant for somebody coming back to this pull request in the future. |
NMinhNguyen
changed the title
[core] Introduce useId hook
[core] Introduce unstable_useId hook
Apr 13, 2020
This was referenced Apr 13, 2020
This was referenced Apr 14, 2020
This was referenced Apr 21, 2020
This was referenced May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @oliviertassinari, 4 usages is probably a good time for abstraction. Raising this as a draft as I'm not too sure of the API. Will add tests later if this draft is good enough to become a proper PR.