[theme] Fix typing for theme.spacing #20435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: a2b2463...d581413 Details of page changes
|
oliviertassinari
approved these changes
Apr 6, 2020
merceyz
previously requested changes
Apr 6, 2020
There was a problem hiding this comment.
https://github.com/mui-org/material-ui/blob/52b80a0b29fe37184bcf1ab1c88bee40958fd197/packages/material-ui/src/styles/createSpacing.d.ts#L7
When passing one argument the return value can be a string now, need to change that as well.
To not break stuff might want to use function overloads for that one
|
@merceyz So something like this? diff --git a/packages/material-ui/src/styles/createSpacing.d.ts b/packages/material-ui/src/styles/createSpacing.d.ts
index bce50f88a..8beed9bff 100644
--- a/packages/material-ui/src/styles/createSpacing.d.ts
+++ b/packages/material-ui/src/styles/createSpacing.d.ts
@@ -5,6 +5,7 @@ export type SpacingArgument = number;
export interface Spacing {
(): number;
(value: SpacingArgument): number;
+ (value: SpacingArgument): string;
(topBottom: SpacingArgument, rightLeft: SpacingArgument): string;
(top: SpacingArgument, rightLeft: SpacingArgument, bottom: SpacingArgument): string;
( |
|
We can unify the call signatures in that case: |
|
Well if you do it like this, you wont be changing the return type for anyone using (value: number): number;
(value: string): string; |
|
Oh definitely, with the solution, it looks obvious, thanks for taking the time 👌. It might change with #16205. |
|
Calling |
|
@m4theushw 👍 smart |
oliviertassinari
force-pushed
the
typescript
branch
from
fd5b9ae
to
d581413
Compare
oliviertassinari
approved these changes
Apr 6, 2020
|
@m4theushw Thanks! |
This was referenced Apr 13, 2020
This was referenced Apr 21, 2020
This was referenced May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR complements #20408