[docs] Refactor markdown parsing #20549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
commented
Apr 14, 2020
| @@ -7,17 +7,6 @@ import { withStyles } from '@material-ui/core/styles'; | |||
| import textToHash from 'docs/src/modules/utils/textToHash'; | |||
| import prism from 'docs/src/modules/components/prism'; | |||
|
|
|||
| // Monkey patch to preserve non-breaking spaces | |||
There was a problem hiding this comment.
They no longer replace non-breaking spaces (https://github.com/markedjs/marked/blob/v0.8.2/lib/marked.js#L553) but they also do not replace the newline symbol \u2424 with newline escape sequences anymore. It's unclear if this affects us.
There was a problem hiding this comment.
No clue, the original motivation was #10252. Probably worth trying +1.
|
No bundle size changes comparing b3dafd8...3260a0a |
eps1lon
commented
Apr 14, 2020
eps1lon
force-pushed
the
docs/markdown-parser
branch
from
f109eda
to
3260a0a
Compare
oliviertassinari
approved these changes
Apr 14, 2020
This was referenced Apr 20, 2020
This was referenced Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to have a single, side-effect free function that parses markdown we use (customizable with renderers for specific elements like heading or link).
This is in preparation for #20539