-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ButtonBase] Fix ripple size when clientX or clientY is 0 #20654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: b506255...4dc7c12 Details of page changes
|
How do you reproduce the issue? |
oliviertassinari
added
the
status: waiting for author
Issue with insufficient information
label
Apr 20, 2020
click the
|
eps1lon
reviewed
Apr 20, 2020
oliviertassinari
added
bug 🐛
Something doesn't work
component: ButtonBase
The React component.
and removed
status: waiting for author
Issue with insufficient information
labels
Apr 20, 2020
oliviertassinari
changed the title
[ButtonBase] fix getting ripple size when clientX or clientY is zero
[ButtonBase] Fix ripple size when clientX or clientY is zero
Apr 20, 2020
oliviertassinari
changed the title
[ButtonBase] Fix ripple size when clientX or clientY is zero
[ButtonBase] Fix ripple size when clientX or clientY is 0
Apr 20, 2020
@jin60641 Thanks |
This was referenced Apr 29, 2020
This was referenced May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#12362
When click Button with
clientX === 0
orclientY === 0
(ex. clientX = 10, clientY = 0), it has errorCannot read property '0' of undefined
(becuase event.touches is undefined in click event).