[l10n] Improve de-DE locale #20684
Merged
[l10n] Improve de-DE locale #20684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: 10767d7...d8b6811 Details of page changes
|
eps1lon
commented
Apr 21, 2020
| @@ -224,7 +224,7 @@ export const deDE = { | |||
| }, | |||
| MuiRating: { | |||
| getLabelText: (value) => `${value} ${value !== 1 ? 'Sterne' : 'Stern'}`, | |||
| emptyLabelText: 'Empty', | |||
| emptyLabelText: 'Keine Wertung', | |||
There was a problem hiding this comment.
I'm not sure if this is the correct translation. "Empty" is pretty meaningless. Is there more context? How would this be displayed?
There was a problem hiding this comment.
You can have more context on https://www.w3.org/WAI/tutorials/forms/custom-controls/#a-star-rating, the label goes instead of 0 Stars in the above link.
There was a problem hiding this comment.
So we should improve Empty as well. Seems like "No Rating" would have actual meaning.
There was a problem hiding this comment.
It depends on how generic we want to be. Sounds fair.
oliviertassinari
changed the title
|
@eps1lon I'm merging as it seems that the changes are already bringing value on their own :). Regarding the rating empty case, if you think that it's worth changing, sure, we could do a follow-up (impacting en-US, and the other locales). |
This was referenced Apr 29, 2020
This was referenced May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds/correct missing strings for de-DE