-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Select] Forward onClick event to menuItem #20739
Merged
oliviertassinari
merged 1 commit into
mui:master
from
marcosvega91:fix/onclick_select_item
Apr 24, 2020
Merged
[Select] Forward onClick event to menuItem #20739
oliviertassinari
merged 1 commit into
mui:master
from
marcosvega91:fix/onclick_select_item
Apr 24, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
approved these changes
Apr 24, 2020
oliviertassinari
added
bug 🐛
Something doesn't work
component: select
This is the name of the generic UI component, not the React module!
PR: ready to ship
labels
Apr 24, 2020
Details of bundle changes.Comparing: 2231349...2ddb744 Details of page changes
|
@marcosvega91 Thanks for the test case :) |
@oliviertassinari i add test for everything hahaahha |
This was referenced Apr 29, 2020
This was referenced May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug 🐛
Something doesn't work
component: select
This is the name of the generic UI component, not the React module!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #20709