[docs] Improve infrastructure #20751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
force-pushed
the
docs-improve-infra
branch
2 times, most recently
from
d76dd1c
to
f742566
Compare
oliviertassinari
force-pushed
the
docs-improve-infra
branch
from
f742566
to
f5c9e03
Compare
Details of bundle changes.Comparing: 79085fc...faf2471 Details of page changes
|
eps1lon
previously requested changes
Apr 26, 2020
| let demos = demosProp; | ||
| let docs = docsProp; | ||
|
|
||
| if (process.env.NODE_ENV !== 'production' && pageFilename && requireRaw) { |
There was a problem hiding this comment.
This should not be in. Not having hot-reload for getInitialProps is a nextjs issue not Material-UI issue. This is creates fudamentally different dev and prod environments for little gain.
Live markdown is available directly in vscode and I'd be surprised if other IDEs don't have an extension for markdown as well.
This sets a dangerous precedent for monkey-patching hot-releoading for every getInitialProps, getStatisProps, getStaticPaths etc.
Eventually this won't work anyway once we move from getInitialProps to getStaticProps which might result in node-only code.
There was a problem hiding this comment.
Ok, let's do it incrementally. I'm removing the change. Let's see how the DX is in the coming days. I guess it's a matter of habit. I always end-up testing how it looks like for the users. Is the text too long, Is the layout correct, etc?
There was a problem hiding this comment.
@timneutkens Has the Next.js team considered to support live reload on getInitialProps/getStatisProps? Related to https://twitter.com/timneutkens/status/1251942933953228802.
There was a problem hiding this comment.
@timneutkens Has the Next.js team considered to support live reload on
getInitialProps/getStatisProps? Related to twitter.com/timneutkens/status/1251942933953228802.
Yes! Won't be part of the fast refresh work but definitely something we want to tackle.
oliviertassinari
force-pushed
the
docs-improve-infra
branch
from
a343689
to
faf2471
Compare
This was referenced Apr 29, 2020
This was referenced May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on the comment #20601 (comment) by @Andrew5569
Solves:
Restore support for live markdown updates in dev mode without a negative impact in prod.I haven't looked into reducing the included languages in the index.html (from #20652). Maybe later, I don't want to make the pull request too overloaded. @eps1lon If you feel otherwise, if you would rather have 1 PR to review or 6, I will make the required changes.