Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Batch small changes #20823

Merged
merged 14 commits into from
Apr 29, 2020

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Apr 28, 2020

  • Close the developer survey 42c32dc: The survey has been running for 22 days, we had 1,450 answers, x2 more than last year. It's probably time to close it. We have to analyze the results now 😅.

  • [l10n] Improve fr-FR value 16bdb64: Thanks @raduchiriac for the report in 9c053f8#r38650085.

  • [docs] Automatically redirect pt to pt-BR 611a655: as discussed with @jaironalves, the /pt/ locale is the most used one. It's also the most translated, at almost 100%. It seems safe to enable auto redirection for this locale, as we have for the Chinese one.

    unnamed

    Legend

    • Language => the primary configured language of the browser
    • userLanguage => the language of the docs
  • [Autocomplete] Improve the heading structure cea1d62: freeSolo has two main use cases, make it explicit.

  • [core] Most of the time, we use aria-hidden as a boolean a4ec727: a nitpick.

  • [l10n] Fix dark mode support of the demo a638ef8: reported by @dtassone on

    Capture d’écran 2020-04-28 à 18 27 38

    https://material-ui.com/guides/localization/#example

  • [docs] Add a new introduction series of videos ee96096: New up-to-date quality content is always appreciated, thanks @AtotheY.

  • [docs] Warn about the a11y implication of changing HTML font size bee571e: ♿️

  • [Autocomplete] Use useControlled instead of custom logic 3f0bed0: I believe there is another case to migrate: the Rating, for another time.

  • [docs] Fix centering of code on mobile 7e64043: a small display bug, it's not centered.

    Capture d’écran 2020-04-28 à 18 32 45
  • [docs] Display a loading state for notifications 18bee68: display a loader instead of an empty state, it also throws an exception.

master:
Capture d’écran 2020-04-28 à 18 34 14

@oliviertassinari oliviertassinari added the umbrella For grouping multiple issues to provide a holistic view label Apr 28, 2020
@mui-pr-bot
Copy link

mui-pr-bot commented Apr 28, 2020

Details of bundle changes.

Comparing: 0ce7487...03d3b2f

Details of page changes
bundle Size Change Size Gzip Change Gzip
/components/backdrop ▼ -990 B (-27.73% ) 2.58 kB -- -1 B
/components/autocomplete ▼ -900 B (-0.90% ) 99 kB -- -1 B
/components/progress ▼ -700 B (-3.33% ) 20.3 kB -- -1 B
/customization/typography ▲ +100 B (+0.87% ) 11.6 kB -- -1 B
/guides/localization ▲ +100 B (+0.87% ) 11.6 kB -- -1 B
/getting-started/learn ▲ +70 B (+0.79% ) 8.97 kB -- -1 B
/_app -- 37 kB -- -1 B
/api-docs/alert-title -- 1.4 kB -- -1 B
/api-docs/alert -- 2.4 kB -- -1 B
/api-docs/app-bar -- 1.94 kB -- -1 B
/api-docs/autocomplete -- 4.54 kB -- -1 B
/api-docs/avatar-group -- 1.51 kB -- -1 B
/api-docs/avatar -- 1.86 kB -- -1 B
/api-docs/backdrop -- 1.72 kB -- -1 B
/api-docs/badge -- 2.13 kB -- -1 B
/api-docs/bottom-navigation-action -- 1.81 kB -- -1 B
/api-docs/bottom-navigation -- 1.7 kB -- -1 B
/api-docs/breadcrumbs -- 1.84 kB -- -1 B
/api-docs/button-base -- 2.33 kB -- -1 B
/api-docs/button-group -- 2.23 kB -- -1 B
/api-docs/button -- 2.56 kB -- -1 B
/api-docs/card-action-area -- 1.58 kB -- -1 B
/api-docs/card-actions -- 1.47 kB -- -1 B
/api-docs/card-content -- 1.45 kB -- -1 B
/api-docs/card-header -- 1.78 kB -- -1 B
/api-docs/card-media -- 1.69 kB -- -1 B
/api-docs/card -- 1.5 kB -- -1 B
/api-docs/checkbox -- 2.3 kB -- -1 B
/api-docs/chip -- 2.46 kB -- -1 B
/api-docs/circular-progress -- 2.07 kB -- -1 B
/api-docs/click-away-listener -- 1.37 kB -- -1 B
/api-docs/collapse -- 2.02 kB -- -1 B
/api-docs/container -- 1.86 kB -- -1 B
/api-docs/css-baseline -- 1.4 kB -- -1 B
/api-docs/dialog-actions -- 1.47 kB -- -1 B
/api-docs/dialog-content-text -- 1.48 kB -- -1 B
/api-docs/dialog-content -- 1.45 kB -- -1 B
/api-docs/dialog-title -- 1.49 kB -- -1 B
/api-docs/dialog -- 2.73 kB -- -1 B
/api-docs/divider -- 1.81 kB -- -1 B
/api-docs/drawer -- 2.13 kB -- -1 B
/api-docs/expansion-panel-actions -- 1.49 kB -- -1 B
/api-docs/expansion-panel-details -- 1.41 kB -- -1 B
/api-docs/expansion-panel-summary -- 1.72 kB -- -1 B
/api-docs/expansion-panel -- 1.97 kB -- -1 B
/api-docs/fab -- 2.11 kB -- -1 B
/api-docs/fade -- 1.39 kB -- -1 B
/api-docs/filled-input -- 2.87 kB -- -1 B
/api-docs/form-control-label -- 1.98 kB -- -1 B
/api-docs/form-control -- 2.36 kB -- -1 B
/api-docs/form-group -- 1.55 kB -- -1 B
/api-docs/form-helper-text -- 1.91 kB -- -1 B
/api-docs/form-label -- 1.84 kB -- -1 B
/api-docs/grid-list-tile-bar -- 1.8 kB -- -1 B
/api-docs/grid-list-tile -- 1.72 kB -- -1 B
/api-docs/grid-list -- 1.62 kB -- -1 B
/api-docs/grid -- 2.56 kB -- -1 B
/api-docs/grow -- 1.44 kB -- -1 B
/api-docs/hidden -- 1.53 kB -- -1 B
/api-docs/icon-button -- 2.1 kB -- -1 B
/api-docs/icon -- 1.78 kB -- -1 B
/api-docs/input-adornment -- 1.93 kB -- -1 B
/api-docs/input-base -- 2.95 kB -- -1 B
/api-docs/input-label -- 2.07 kB -- -1 B
/api-docs/input -- 2.83 kB -- -1 B
/api-docs/linear-progress -- 2.03 kB -- -1 B
/api-docs/link -- 1.93 kB -- -1 B
/api-docs/list-item-avatar -- 1.5 kB -- -1 B
/api-docs/list-item-icon -- 1.51 kB -- -1 B
/api-docs/list-item-secondary-action -- 1.47 kB -- -1 B
/api-docs/list-item-text -- 1.79 kB -- -1 B
/api-docs/list-item -- 2.25 kB -- -1 B
/api-docs/list-subheader -- 1.77 kB -- -1 B
/api-docs/list -- 1.68 kB -- -1 B
/api-docs/menu-item -- 1.74 kB -- -1 B
/api-docs/menu-list -- 1.57 kB -- -1 B
/api-docs/menu -- 2.4 kB -- -1 B
/api-docs/mobile-stepper -- 1.93 kB -- -1 B
/api-docs/modal -- 2.42 kB -- -1 B
/api-docs/native-select -- 2.08 kB -- -1 B
/api-docs/no-ssr -- 1.3 kB -- -1 B
/api-docs/outlined-input -- 2.98 kB -- -1 B
/api-docs/pagination-item -- 1.97 kB -- -1 B
/api-docs/pagination -- 2.24 kB -- -1 B
/api-docs/paper -- 1.87 kB -- -1 B
/api-docs/popover -- 2.69 kB -- -1 B
/api-docs/popper -- 1.91 kB -- -1 B
/api-docs/portal -- 1.34 kB -- -1 B
/api-docs/radio-group -- 1.45 kB -- -1 B
/api-docs/radio -- 2.12 kB -- -1 B
/api-docs/rating -- 2.49 kB -- -1 B
/api-docs/root-ref -- 1.41 kB -- -1 B
/api-docs/scoped-css-baseline -- 1.4 kB -- -1 B
/api-docs/select -- 2.94 kB -- -1 B
/api-docs/skeleton -- 1.77 kB -- -1 B
/api-docs/slide -- 1.54 kB -- -1 B
/api-docs/slider -- 3.11 kB -- -1 B
/api-docs/snackbar-content -- 1.61 kB -- -1 B
/api-docs/snackbar -- 2.71 kB -- -1 B
/api-docs/speed-dial-action -- 2.04 kB -- -1 B
/api-docs/speed-dial-icon -- 1.55 kB -- -1 B
/api-docs/speed-dial -- 2.3 kB -- -1 B
/api-docs/step-button -- 1.63 kB -- -1 B
/api-docs/step-connector -- 1.54 kB -- -1 B
/api-docs/step-content -- 1.72 kB -- -1 B
/api-docs/step-icon -- 1.57 kB -- -1 B
/api-docs/step-label -- 1.9 kB -- -1 B
/api-docs/step -- 1.64 kB -- -1 B
/api-docs/stepper -- 1.84 kB -- -1 B
/api-docs/svg-icon -- 2.26 kB -- -1 B
/api-docs/swipeable-drawer -- 2 kB -- -1 B
/api-docs/switch -- 2.46 kB -- -1 B
/api-docs/tab-scroll-button -- 1.61 kB -- -1 B
/api-docs/tab -- 1.99 kB -- -1 B
/api-docs/table-body -- 1.47 kB -- -1 B
/api-docs/table-cell -- 2.13 kB -- -1 B
/api-docs/table-container -- 1.48 kB -- -1 B
/api-docs/table-footer -- 1.47 kB -- -1 B
/api-docs/table-head -- 1.46 kB -- -1 B
/api-docs/table-pagination -- 2.46 kB -- -1 B
/api-docs/table-row -- 1.69 kB -- -1 B
/api-docs/table-sort-label -- 1.83 kB -- -1 B
/api-docs/table -- 1.68 kB -- -1 B
/api-docs/tabs -- 2.56 kB -- -1 B
/api-docs/text-field -- 3.18 kB -- -1 B
/api-docs/textarea-autosize -- 1.13 kB -- -1 B
/api-docs/toggle-button-group -- 1.86 kB -- -1 B
/api-docs/toggle-button -- 1.8 kB -- -1 B
/api-docs/toolbar -- 1.65 kB -- -1 B
/api-docs/tooltip -- 2.54 kB -- -1 B
/api-docs/tree-item -- 1.88 kB -- -1 B
/api-docs/tree-view -- 1.92 kB -- -1 B
/api-docs/typography -- 2.59 kB -- -1 B
/api-docs/zoom -- 1.41 kB -- -1 B
/blog/2019-developer-survey-results -- 6.36 kB -- -1 B
/blog/2019 -- 4.24 kB -- -1 B
/blog/2020-introducing-sketch -- 3.5 kB -- -1 B
/blog/2020-q1-update -- 4.33 kB -- -1 B
/blog/april-2019-update -- 3.13 kB -- -1 B
/blog/august-2019-update -- 2.24 kB -- -1 B
/blog/december-2019-update -- 2.37 kB -- -1 B
/blog/july-2019-update -- 2.13 kB -- -1 B
/blog/june-2019-update -- 2.01 kB -- -1 B
/blog/march-2019-update -- 2.54 kB -- -1 B
/blog/material-ui-v1-is-out -- 6.67 kB -- -1 B
/blog/material-ui-v4-is-out -- 9.69 kB -- -1 B
/blog/may-2019-update -- 2.35 kB -- -1 B
/blog/november-2019-update -- 2.75 kB -- -1 B
/blog/october-2019-update -- 2.5 kB -- -1 B
/blog/september-2019-update -- 2.68 kB -- -1 B
/company/about -- 1.74 kB -- -1 B
/company/contact -- 1.33 kB -- -1 B
/company/jobs -- 1.35 kB -- -1 B
/components/about-the-lab -- 6.08 kB -- -1 B
/components/alert -- 12.5 kB -- -1 B
/components/app-bar -- 30 kB -- -1 B
/components/avatars -- 8.83 kB -- -1 B
/components/badges -- 15.4 kB -- -1 B
/components/bottom-navigation -- 6.27 kB -- -1 B
/components/box -- 8.05 kB -- -1 B
/components/breadcrumbs -- 14.7 kB -- -1 B
/components/button-group -- 7.31 kB -- -1 B
/components/buttons -- 26.2 kB -- -1 B
/components/cards -- 17.2 kB -- -1 B
/components/checkboxes -- 16.3 kB -- -1 B
/components/chips -- 21.8 kB -- -1 B
/components/click-away-listener -- 4.46 kB -- -1 B
/components/container -- 3.72 kB -- -1 B
/components/css-baseline -- 6.74 kB -- -1 B
/components/dialogs -- 42.8 kB -- -1 B
/components/dividers -- 12.7 kB -- -1 B
/components/drawers -- 31.5 kB -- -1 B
/components/expansion-panels -- 20.4 kB -- -1 B
/components/floating-action-button -- 10.4 kB -- -1 B
/components/grid-list -- 12.1 kB -- -1 B
/components/grid -- 32.4 kB -- -1 B
/components/hidden -- 10.6 kB -- -1 B
/components/icons -- 24.7 kB -- -1 B
/components/links -- 6.91 kB -- -1 B
/components/lists -- 26.5 kB -- -1 B
/components/material-icons -- 729 kB -- -1 B
/components/menus -- 24.9 kB -- -1 B
/components/modal -- 11.9 kB -- -1 B
/components/no-ssr -- 5.11 kB -- -1 B
/components/pagination -- 9.44 kB -- -1 B
/components/paper -- 3.49 kB -- -1 B
/components/pickers -- 6 kB -- -1 B
/components/popover -- 17.4 kB -- -1 B
/components/popper -- 23.4 kB -- -1 B
/components/portal -- 3 kB -- -1 B
/components/radio-buttons -- 14.8 kB -- -1 B
/components/rating -- 10.8 kB -- -1 B
/components/selects -- 30.8 kB -- -1 B
/components/skeleton -- 10.2 kB -- -1 B
/components/slider -- 15.6 kB -- -1 B
/components/snackbars -- 28.6 kB -- -1 B
/components/speed-dial -- 14.4 kB -- -1 B
/components/steppers -- 36.6 kB -- -1 B
/components/switches -- 16.4 kB -- -1 B
/components/tables -- 143 kB -- -1 B
/components/tabs -- 19.8 kB -- -1 B
/components/text-fields -- 54.7 kB -- -1 B
/components/textarea-autosize -- 2.94 kB -- -1 B
/components/toggle-button -- 10.5 kB -- -1 B
/components/tooltips -- 16.5 kB -- -1 B
/components/transfer-list -- 9.68 kB -- -1 B
/components/transitions -- 11.5 kB -- -1 B
/components/tree-view -- 11.2 kB -- -1 B
/components/typography -- 9.91 kB -- -1 B
/components/use-media-query -- 12.9 kB -- -1 B
/customization/breakpoints -- 15.6 kB -- -1 B
/customization/color -- 20.9 kB -- -1 B
/customization/components -- 38.4 kB -- -1 B
/customization/default-theme -- 8.8 kB -- -1 B
/customization/density -- 9.75 kB -- -1 B
/customization/globals -- 4.72 kB -- -1 B
/customization/palette -- 13.3 kB -- -1 B
/customization/spacing -- 2.61 kB -- -1 B
/customization/theming -- 16.8 kB -- -1 B
/customization/z-index -- 3.13 kB -- -1 B
/discover-more/backers -- 2.94 kB -- -1 B
/discover-more/changelog -- 1.44 kB -- -1 B
/discover-more/languages -- 3.43 kB -- -1 B
/discover-more/related-projects -- 7.95 kB -- -1 B
/discover-more/roadmap -- 3.72 kB -- -1 B
/discover-more/showcase -- 13.4 kB -- -1 B
/discover-more/team -- 6.61 kB -- -1 B
/discover-more/vision -- 6.59 kB -- -1 B
/getting-started/example-projects -- 6.8 kB -- -1 B
/getting-started/faq -- 36.1 kB -- -1 B
/getting-started/installation -- 7.85 kB -- -1 B
/getting-started/support -- 8.95 kB -- -1 B
/getting-started/supported-components -- 6.42 kB -- -1 B
/getting-started/supported-platforms -- 5.76 kB -- -1 B
/getting-started/templates -- 8.91 kB -- -1 B
/getting-started/templates/album -- 5.58 kB -- -1 B
/getting-started/templates/blog -- 7.44 kB -- -1 B
/getting-started/templates/checkout -- 11.2 kB -- -1 B
/getting-started/templates/dashboard -- 8.86 kB -- -1 B
/getting-started/templates/pricing -- 7.8 kB -- -1 B
/getting-started/templates/sign-in-side -- 9.29 kB -- -1 B
/getting-started/templates/sign-in -- 9.53 kB -- -1 B
/getting-started/templates/sign-up -- 9.64 kB -- -1 B
/getting-started/templates/sticky-footer -- 1.54 kB -- -1 B
/getting-started/usage -- 9.58 kB -- -1 B
/guides/api -- 15.8 kB -- -1 B
/guides/composition -- 14.9 kB -- -1 B
/guides/flow -- 2.26 kB -- -1 B
/guides/interoperability -- 16.3 kB -- -1 B
/guides/migration-v0x -- 7.39 kB -- -1 B
/guides/migration-v3 -- 19.2 kB -- -1 B
/guides/minimizing-bundle-size -- 8.7 kB -- -1 B
/guides/responsive-ui -- 4.27 kB -- -1 B
/guides/right-to-left -- 6.77 kB -- -1 B
/guides/server-rendering -- 8.75 kB -- -1 B
/guides/testing -- 8.61 kB -- -1 B
/guides/typescript -- 14.6 kB -- -1 B
/performance/table-component -- 1.44 kB -- -1 B
/performance/table-emotion -- 8.49 kB -- -1 B
/performance/table-hook -- 2.23 kB -- -1 B
/performance/table-mui -- 4.48 kB -- -1 B
/performance/table-raw -- 613 B -- -1 B
/performance/table-styled-components -- 2.61 kB -- -1 B
/premium-themes/onepirate -- 7.26 kB -- -1 B
/premium-themes/onepirate/forgot-password -- 1.01 kB -- -1 B
/premium-themes/onepirate/privacy -- 4.43 kB -- -1 B
/premium-themes/onepirate/sign-in -- 1.07 kB -- -1 B
/premium-themes/onepirate/sign-up -- 1.12 kB -- -1 B
/premium-themes/onepirate/terms -- 11.8 kB -- -1 B
/premium-themes/paperbase -- 8.95 kB -- -1 B
/styles/advanced -- 33.3 kB -- -1 B
/styles/api -- 17 kB -- -1 B
/styles/basics -- 16.5 kB -- -1 B
/system/api -- 5.96 kB -- -1 B
/system/basics -- 27.4 kB -- -1 B
/system/borders -- 4.1 kB -- -1 B
/system/display -- 6.55 kB -- -1 B
/system/flexbox -- 5.85 kB -- -1 B
/system/palette -- 4.35 kB -- -1 B
/system/positions -- 2.53 kB -- -1 B
/system/shadows -- 3.85 kB -- -1 B
/system/sizing -- 3.53 kB -- -1 B
/system/spacing -- 6.01 kB -- -1 B
/system/typography -- 4.41 kB -- -1 B
/versions -- 23.7 kB -- -1 B
docs:chunk:shared -- 61.6 kB -- -1 B
docs:shared:chunk/commons -- 5.99 kB -- -1 B
docs:shared:chunk/framework -- 42.3 kB -- -1 B
docs:shared:runtime/main -- 6.78 kB -- -1 B
docs:shared:runtime/webpack -- 1.24 kB -- -1 B
bundle Size Change Size Gzip Change Gzip
useAutocomplete ▲ +16 B (+0.11% ) 15 kB ▲ +1 B (+0.02% ) 5.26 kB
@material-ui/lab ▲ +11 B (+0.01% ) 203 kB ▼ -10 B (-0.02% ) 60.3 kB
Autocomplete ▲ +11 B (+0.01% ) 136 kB ▼ -8 B (-0.02% ) 42.8 kB
@material-ui/core ▼ -5 B (-0.00% ) 373 kB ▼ -14 B (-0.01% ) 102 kB
Alert ▼ -5 B (-0.01% ) 87.6 kB ▼ -9 B (-0.03% ) 27.8 kB
Pagination ▼ -5 B (-0.01% ) 88.8 kB ▼ -9 B (-0.03% ) 27.5 kB
Select ▼ -5 B (-0.00% ) 120 kB ▼ -9 B (-0.03% ) 35.9 kB
TextField ▼ -5 B (-0.00% ) 129 kB ▼ -9 B (-0.02% ) 38 kB
Rating ▼ -5 B (-0.01% ) 75.3 kB ▼ -8 B (-0.03% ) 24.3 kB
Avatar ▼ -5 B (-0.01% ) 69.9 kB ▼ -7 B (-0.03% ) 21.9 kB
Checkbox ▼ -5 B (-0.01% ) 86.5 kB ▼ -7 B (-0.03% ) 27.5 kB
NativeSelect ▼ -5 B (-0.01% ) 81.6 kB ▼ -7 B (-0.03% ) 25.9 kB
Radio ▼ -5 B (-0.01% ) 87.5 kB ▼ -7 B (-0.03% ) 27.9 kB
SpeedDialIcon ▼ -5 B (-0.01% ) 69.3 kB ▼ -7 B (-0.03% ) 21.8 kB
StepIcon ▼ -5 B (-0.01% ) 69.3 kB ▼ -7 B (-0.03% ) 21.6 kB
@material-ui/core[umd] ▼ -5 B (-0.00% ) 328 kB ▼ -6 B (-0.01% ) 94.4 kB
StepLabel ▼ -5 B (-0.01% ) 73.2 kB ▼ -6 B (-0.03% ) 22.7 kB
SvgIcon ▼ -5 B (-0.01% ) 67.7 kB ▼ -6 B (-0.03% ) 21.2 kB
TablePagination ▼ -5 B (-0.00% ) 147 kB ▼ -6 B (-0.01% ) 43.3 kB
Tabs ▼ -5 B (-0.01% ) 90.3 kB ▼ -6 B (-0.02% ) 29 kB
AvatarGroup ▼ -5 B (-0.01% ) 70.9 kB ▼ -5 B (-0.02% ) 22.5 kB
Chip ▼ -5 B (-0.01% ) 87 kB ▼ -5 B (-0.02% ) 26.8 kB
Breadcrumbs ▼ -5 B (-0.01% ) 84.8 kB ▼ -4 B (-0.01% ) 26.9 kB
PaginationItem ▼ -5 B (-0.01% ) 85.2 kB ▼ -4 B (-0.02% ) 26.4 kB
TableSortLabel ▼ -5 B (-0.01% ) 81.7 kB ▼ -4 B (-0.02% ) 26 kB
StepButton ▼ -5 B (-0.01% ) 86.6 kB ▼ -3 B (-0.01% ) 27.5 kB
TabScrollButton ▼ -5 B (-0.01% ) 81.3 kB ▼ -3 B (-0.01% ) 25.5 kB
SpeedDialAction -- 122 kB ▼ -8 B (-0.02% ) 38.9 kB
InputBase -- 75.4 kB ▼ -7 B (-0.03% ) 23.7 kB
Tooltip -- 106 kB ▼ -7 B (-0.02% ) 33.7 kB
FilledInput -- 78.3 kB ▼ -6 B (-0.02% ) 24.4 kB
Input -- 77.3 kB ▼ -6 B (-0.02% ) 24.2 kB
MenuItem -- 82.5 kB ▼ -6 B (-0.02% ) 25.9 kB
OutlinedInput -- 79.3 kB ▼ -6 B (-0.02% ) 24.8 kB
RadioGroup -- 68.6 kB ▼ -6 B (-0.03% ) 21.3 kB
TreeView -- 73.2 kB ▼ -6 B (-0.03% ) 23 kB
Backdrop -- 72.7 kB ▼ -5 B (-0.02% ) 22.5 kB
ButtonBase -- 78.3 kB ▼ -5 B (-0.02% ) 24.7 kB
Collapse -- 77.3 kB ▼ -5 B (-0.02% ) 22.8 kB
Fab -- 81.1 kB ▼ -5 B (-0.02% ) 25.4 kB
ListItem -- 81.4 kB ▼ -5 B (-0.02% ) 25.6 kB
SwipeableDrawer -- 97 kB ▼ -5 B (-0.02% ) 30.5 kB
AppBar -- 68.7 kB ▼ -4 B (-0.02% ) 21.6 kB
FormGroup -- 66.7 kB ▼ -4 B (-0.02% ) 20.8 kB
List -- 67 kB ▼ -4 B (-0.02% ) 20.9 kB
Menu -- 93.3 kB ▼ -4 B (-0.01% ) 28.8 kB
MenuList -- 70.7 kB ▼ -4 B (-0.02% ) 22.2 kB
Popover -- 87.7 kB ▼ -4 B (-0.01% ) 27.2 kB
Switch -- 85.7 kB ▼ -4 B (-0.01% ) 27.1 kB
ToggleButtonGroup -- 67.9 kB ▼ -4 B (-0.02% ) 21.4 kB
Typography -- 68.3 kB ▼ -4 B (-0.02% ) 21.4 kB
@material-ui/system -- 17.2 kB ▼ -3 B (-0.07% ) 4.52 kB
AlertTitle -- 68.9 kB ▼ -3 B (-0.01% ) 21.7 kB
Badge -- 70 kB ▼ -3 B (-0.01% ) 21.9 kB
BottomNavigationAction -- 79.8 kB ▼ -3 B (-0.01% ) 25.4 kB
CardActionArea -- 79.4 kB ▼ -3 B (-0.01% ) 25.2 kB
CardActions -- 66.8 kB ▼ -3 B (-0.01% ) 21 kB
CardHeader -- 69.8 kB ▼ -3 B (-0.01% ) 22 kB
CircularProgress -- 68.8 kB ▼ -3 B (-0.01% ) 21.7 kB
CssBaseline -- 66.7 kB ▼ -3 B (-0.01% ) 21 kB
Dialog -- 87.7 kB ▼ -3 B (-0.01% ) 27.5 kB
FormControl -- 69.1 kB ▼ -3 B (-0.01% ) 21.6 kB
FormHelperText -- 68 kB ▼ -3 B (-0.01% ) 21.2 kB
FormLabel -- 68.2 kB ▼ -3 B (-0.01% ) 21.2 kB
Grid -- 69.8 kB ▼ -3 B (-0.01% ) 22 kB
GridListTile -- 68.4 kB ▼ -3 B (-0.01% ) 21.5 kB
GridListTileBar -- 67.9 kB ▼ -3 B (-0.01% ) 21.3 kB
Hidden -- 70.7 kB ▼ -3 B (-0.01% ) 22.3 kB
IconButton -- 80.5 kB ▼ -3 B (-0.01% ) 25.2 kB
InputLabel -- 70 kB ▼ -3 B (-0.01% ) 21.7 kB
LinearProgress -- 70.1 kB ▼ -3 B (-0.01% ) 21.7 kB
Link -- 71.3 kB ▼ -3 B (-0.01% ) 22.6 kB
ListItemIcon -- 66.9 kB ▼ -3 B (-0.01% ) 21 kB
ListItemText -- 69.7 kB ▼ -3 B (-0.01% ) 22 kB
Paper -- 67.1 kB ▼ -3 B (-0.01% ) 20.9 kB
Skeleton -- 67.7 kB ▼ -3 B (-0.01% ) 21.4 kB
Snackbar -- 80.3 kB ▼ -3 B (-0.01% ) 25.3 kB
SnackbarContent -- 68.2 kB ▼ -3 B (-0.01% ) 21.3 kB
Step -- 67.4 kB ▼ -3 B (-0.01% ) 21.2 kB
Tab -- 80.7 kB ▼ -3 B (-0.01% ) 25.7 kB
TableFooter -- 66.9 kB ▼ -3 B (-0.01% ) 21 kB
TreeItem -- 80.1 kB ▼ -3 B (-0.01% ) 25.5 kB
BottomNavigation -- 67.1 kB ▼ -2 B (-0.01% ) 21.1 kB
Box -- 73.6 kB ▼ -2 B (-0.01% ) 22.4 kB
ButtonGroup -- 87.7 kB ▼ -2 B (-0.01% ) 27.1 kB
Card -- 67.6 kB ▼ -2 B (-0.01% ) 21.2 kB
CardContent -- 66.7 kB ▼ -2 B (-0.01% ) 20.9 kB
CardMedia -- 67.1 kB ▼ -2 B (-0.01% ) 21.1 kB
Drawer -- 89.6 kB ▼ -2 B (-0.01% ) 27.3 kB
Fade -- 32.6 kB ▼ -2 B (-0.02% ) 9.83 kB
FormControlLabel -- 70.2 kB ▼ -2 B (-0.01% ) 22.1 kB
Icon -- 67.5 kB ▼ -2 B (-0.01% ) 21.2 kB
InputAdornment -- 69.8 kB ▼ -2 B (-0.01% ) 22.1 kB
ListItemAvatar -- 66.8 kB ▼ -2 B (-0.01% ) 21 kB
ListItemSecondaryAction -- 66.7 kB ▼ -2 B (-0.01% ) 21 kB
ListSubheader -- 67.5 kB ▼ -2 B (-0.01% ) 21.3 kB
ScopedCssBaseline -- 67.5 kB ▼ -2 B (-0.01% ) 21.2 kB
Slider -- 80.6 kB ▼ -2 B (-0.01% ) 25.8 kB
StepConnector -- 67.4 kB ▼ -2 B (-0.01% ) 21.3 kB
StepContent -- 73.9 kB ▼ -2 B (-0.01% ) 23.2 kB
Stepper -- 69.6 kB ▼ -2 B (-0.01% ) 22 kB
Table -- 67.3 kB ▼ -2 B (-0.01% ) 21.2 kB
TableBody -- 66.8 kB ▼ -2 B (-0.01% ) 21 kB
TableCell -- 68.8 kB ▼ -2 B (-0.01% ) 21.7 kB
TableContainer -- 66.7 kB ▼ -2 B (-0.01% ) 20.9 kB
TableHead -- 66.8 kB ▼ -2 B (-0.01% ) 21 kB
TableRow -- 67.2 kB ▼ -2 B (-0.01% ) 21.1 kB
Toolbar -- 67 kB ▼ -2 B (-0.01% ) 21.1 kB
Button -- 84 kB ▼ -1 B (-0.00% ) 25.9 kB
DialogContent -- 66.9 kB ▼ -1 B (-0.00% ) 21 kB
DialogTitle -- 69 kB ▼ -1 B (-0.00% ) 21.7 kB
Divider -- 67.4 kB ▼ -1 B (-0.00% ) 21.2 kB
ExpansionPanel -- 76.4 kB ▼ -1 B (-0.00% ) 24.1 kB
ExpansionPanelDetails -- 66.7 kB ▼ -1 B (-0.00% ) 20.9 kB
GridList -- 67.2 kB ▼ -1 B (-0.00% ) 21.2 kB
Grow -- 33.2 kB ▼ -1 B (-0.01% ) 10.1 kB
MobileStepper -- 72.6 kB ▼ -1 B (-0.00% ) 22.9 kB
Slide -- 34.6 kB ▼ -1 B (-0.01% ) 10.4 kB
SpeedDial -- 90.6 kB ▼ -1 B (-0.00% ) 28.8 kB
styles/createMuiTheme -- 22.2 kB ▼ -1 B (-0.01% ) 7.71 kB
ToggleButton -- 80.4 kB ▼ -1 B (-0.00% ) 25.6 kB
Zoom -- 32.6 kB ▼ -1 B (-0.01% ) 9.82 kB
@material-ui/styles -- 52 kB -- 15.6 kB
ClickAwayListener -- 4.13 kB -- 1.66 kB
colorManipulator -- 3.88 kB -- 1.52 kB
Container -- 67.9 kB -- 21.3 kB
DialogActions -- 66.8 kB -- 21 kB
DialogContentText -- 68.8 kB -- 21.6 kB
docs:/ -- 11.7 kB -- -1 B
docs:/_app -- 37 kB -- -1 B
ExpansionPanelActions -- 66.8 kB -- 21 kB
ExpansionPanelSummary -- 82.5 kB -- 26.2 kB
Modal -- 15 kB -- 5.23 kB
NoSsr -- 2.18 kB -- 1.03 kB
Popper -- 28.7 kB -- 10.3 kB
Portal -- 2.87 kB -- 1.29 kB
RootRef -- 4.62 kB -- 1.76 kB
TextareaAutosize -- 5.23 kB -- 2.19 kB
useMediaQuery -- 2.56 kB -- 1.06 kB
useScrollTrigger -- 2.66 kB -- 1.08 kB

Generated by 🚫 dangerJS against 03d3b2f

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Apr 28, 2020

@eps1lon There is another issue with the notification I didn't mention: it throws when clicking before the XHR request is resolved (It's a regression I have introduced).

Capture d’écran 2020-04-28 à 20 02 01

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 28, 2020
@oliviertassinari oliviertassinari removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 28, 2020
(count, message) => (message.id > lastSeen ? count + 1 : count),
0,
);
const messageList = messages
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const messageList = messages
const messageList = Array.isArray(messages)

?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the advantage?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s more explicit but ultimately doesn’t need to happen.

});
document.cookie = `lastSeenNotification=${messageList[0].id};path=/;max-age=31536000`;

if (messageList) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All though it shouldn't happen if this is an empty array below will still throw.

Suggested change
if (messageList) {
if (messageList && messageList.length > 0) {

<Badge
color="secondary"
badgeContent={
messageList
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use Array.isArray here too :) I won't point out the others

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
umbrella For grouping multiple issues to provide a holistic view
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants