-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pagination] Refactor boundaryCount #20826
Merged
oliviertassinari
merged 1 commit into
mui:master
from
mbrookes:pagination-remove-adjustment
Apr 29, 2020
Merged
[Pagination] Refactor boundaryCount #20826
oliviertassinari
merged 1 commit into
mui:master
from
mbrookes:pagination-remove-adjustment
Apr 29, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During development the boundaryCount prop's name and meaning changed, along with its default value. For expedience an internal adjustment was used as a temporary stop-gap to allow code that depended on the previous default to continue to function. This PR circles back to clean that up.
mbrookes
added
the
component: pagination
This is the name of the generic UI component, not the React module!
label
Apr 28, 2020
Details of bundle changes.Comparing: 72ac760...9378ce7 Details of page changes
|
oliviertassinari
changed the title
[Pagination] Remove boundaryCount adjustment
[Pagination] Refactor boundaryCount
Apr 29, 2020
This was referenced May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During development the boundaryCount prop's name and meaning changed, along with its default value. For expedience an internal adjustment was used as a temporary stop-gap to allow code that depended on the previous default to continue to function. This PR circles back to clean that up.