-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Fix table zebra customization demo #20870
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current "Custom Table" example in the documentation shows how to do a zebra pattern. However, when used with a table header it contains two dark rows next to each other. This resolves it by making even rows (counting the header) darker.
Details of bundle changes.Comparing: f3fa91b...309591d Details of page changes
|
oliviertassinari
changed the title
Update Custom Table Example
[docs] Fix table zebra customization demo
May 2, 2020
oliviertassinari
added
component: table
This is the name of the generic UI component, not the React module!
docs
Improvements or additions to the documentation
labels
May 2, 2020
oliviertassinari
approved these changes
May 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rkrueger11 Thanks for raising the issue! |
Oh nice. Thanks @oliviertassinari - and big thank you for this library, it's my favorite React UI library by far. |
This was referenced May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: table
This is the name of the generic UI component, not the React module!
docs
Improvements or additions to the documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current "Custom Table" example in the documentation shows how to do a zebra pattern. However, when used with a table header it contains two dark rows next to each other. This resolves it by making even rows (counting the header) darker.