[docs] Improve svgr documentation #20893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the `@svgr/webpack` loader it loads the svg files as a js module exporting a component named as ReactComponent and the source of the svg as the default export. The example is invalid because it's adding at the component attribute the default export and that causes the error: ``` Failed to execute 'createElement' on 'Document': The tag name provided ```
Details of bundle changes.Comparing: 4bfcbec...256ae6e Details of page changes
|
|
@tavantzo Is that's because you are coming from CRA that overrides the behavior of @svgr/webpack? |
|
It seems to be confirmed with https://react-svgr.com/docs/webpack/#using-with-url-loader-or-file-loader. |
oliviertassinari
changed the title
oliviertassinari
approved these changes
May 3, 2020
Sorry, I had to add a reference at the svgr documentation as well. |
mbrookes
previously requested changes
May 3, 2020
Co-authored-by: Matt <github@nospam.33m.co>
Co-authored-by: Matt <github@nospam.33m.co>
Co-authored-by: Matt <github@nospam.33m.co>
|
@tavantzo It's a great first pull request on Material-UI 👌🏻. Thank you for working on it! |
This was referenced May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the
@svgr/webpackloader it loads the svg files as a js module exporting a component named as ReactComponent and the source of the svg as the default export.The example is invalid because it's adding at the component attribute the default export and that causes the error: