Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Popover] Deprecate transition onX props #22202

Merged
merged 4 commits into from
Aug 15, 2020
Merged

[Popover] Deprecate transition onX props #22202

merged 4 commits into from
Aug 15, 2020

Conversation

mbrookes
Copy link
Member

@mbrookes mbrookes commented Aug 14, 2020 •
edited
Loading

Popover

The onE* transition props are deprecated. Use TransitionProps instead.

<Popover
-  onEnter={onEnter}
-  onEntered={onEntered},
-  onEntering={onEntered},
-  onExit={onEntered},
-  onExited={onEntered},
-  onExiting={onEntered}
+  TransitionProps={{
+    onEnter,
+    onEntered,
+    onEntering,
+    onExit,
+    onExited,
+    onExiting,
+  }}
/>

Ref #22184

@mbrookes mbrookes added component: Popover The React component. deprecation New deprecation message labels Aug 14, 2020
@github-actions github-actions bot mentioned this pull request Aug 14, 2020
Closed
@mui-pr-bot
Copy link

mui-pr-bot commented Aug 14, 2020 •
edited
Loading

Details of bundle changes.

Comparing: 07943fb...9d64fe3

Details of page changes
bundle Size Change Size Gzip Change Gzip
/api-docs/popover ▲ +50 B (+1.85% ) 2.75 kB -- -1 B
/components/button-group ▲ +10 B (+0.13% ) 7.81 kB -- -1 B
/components/transfer-list ▲ +10 B (+0.10% ) 9.78 kB -- -1 B
/getting-started/templates/blog ▲ +10 B (+0.13% ) 7.45 kB -- -1 B
/getting-started/templates/pricing ▲ +10 B (+0.13% ) 7.79 kB -- -1 B
/getting-started/templates/sign-in-side ▲ +10 B (+0.12% ) 8.22 kB -- -1 B
/system/palette ▲ +10 B (+0.24% ) 4.16 kB -- -1 B
/_app -- 35.8 kB -- -1 B
/api-docs/accordion-actions -- 1.48 kB -- -1 B
/api-docs/accordion-details -- 1.4 kB -- -1 B
/api-docs/accordion-summary -- 1.7 kB -- -1 B
/api-docs/accordion -- 1.97 kB -- -1 B
/api-docs/alert-title -- 1.4 kB -- -1 B
/api-docs/alert -- 2.4 kB -- -1 B
/api-docs/app-bar -- 1.94 kB -- -1 B
/api-docs/autocomplete -- 4.62 kB -- -1 B
/api-docs/avatar-group -- 1.51 kB -- -1 B
/api-docs/avatar -- 1.88 kB -- -1 B
/api-docs/backdrop -- 1.73 kB -- -1 B
/api-docs/badge -- 2.25 kB -- -1 B
/api-docs/bottom-navigation-action -- 1.81 kB -- -1 B
/api-docs/bottom-navigation -- 1.7 kB -- -1 B
/api-docs/breadcrumbs -- 1.79 kB -- -1 B
/api-docs/button-base -- 2.22 kB -- -1 B
/api-docs/button-group -- 2.22 kB -- -1 B
/api-docs/button -- 2.53 kB -- -1 B
/api-docs/card-action-area -- 1.58 kB -- -1 B
/api-docs/card-actions -- 1.47 kB -- -1 B
/api-docs/card-content -- 1.45 kB -- -1 B
/api-docs/card-header -- 1.78 kB -- -1 B
/api-docs/card-media -- 1.69 kB -- -1 B
/api-docs/card -- 1.5 kB -- -1 B
/api-docs/checkbox -- 2.3 kB -- -1 B
/api-docs/chip -- 2.46 kB -- -1 B
/api-docs/circular-progress -- 2.09 kB -- -1 B
/api-docs/click-away-listener -- 1.45 kB -- -1 B
/api-docs/collapse -- 2.13 kB -- -1 B
/api-docs/container -- 1.83 kB -- -1 B
/api-docs/css-baseline -- 1.4 kB -- -1 B
/api-docs/dialog-actions -- 1.47 kB -- -1 B
/api-docs/dialog-content-text -- 1.48 kB -- -1 B
/api-docs/dialog-content -- 1.45 kB -- -1 B
/api-docs/dialog-title -- 1.49 kB -- -1 B
/api-docs/dialog -- 2.79 kB -- -1 B
/api-docs/divider -- 1.81 kB -- -1 B
/api-docs/drawer -- 2.13 kB -- -1 B
/api-docs/expansion-panel-actions -- 1.55 kB -- -1 B
/api-docs/expansion-panel-details -- 1.47 kB -- -1 B
/api-docs/expansion-panel-summary -- 1.84 kB -- -1 B
/api-docs/expansion-panel -- 2.04 kB -- -1 B
/api-docs/fab -- 2.1 kB -- -1 B
/api-docs/fade -- 1.5 kB -- -1 B
/api-docs/filled-input -- 2.87 kB -- -1 B
/api-docs/form-control-label -- 1.99 kB -- -1 B
/api-docs/form-control -- 2.36 kB -- -1 B
/api-docs/form-group -- 1.55 kB -- -1 B
/api-docs/form-helper-text -- 1.91 kB -- -1 B
/api-docs/form-label -- 1.84 kB -- -1 B
/api-docs/grid-list-tile-bar -- 1.8 kB -- -1 B
/api-docs/grid-list-tile -- 1.73 kB -- -1 B
/api-docs/grid-list -- 1.63 kB -- -1 B
/api-docs/grid -- 2.56 kB -- -1 B
/api-docs/grow -- 1.55 kB -- -1 B
/api-docs/hidden -- 1.53 kB -- -1 B
/api-docs/icon-button -- 2.08 kB -- -1 B
/api-docs/icon -- 1.78 kB -- -1 B
/api-docs/input-adornment -- 1.95 kB -- -1 B
/api-docs/input-base -- 2.95 kB -- -1 B
/api-docs/input-label -- 2.07 kB -- -1 B
/api-docs/input -- 2.83 kB -- -1 B
/api-docs/linear-progress -- 2.03 kB -- -1 B
/api-docs/link -- 1.94 kB -- -1 B
/api-docs/list-item-avatar -- 1.51 kB -- -1 B
/api-docs/list-item-icon -- 1.51 kB -- -1 B
/api-docs/list-item-secondary-action -- 1.47 kB -- -1 B
/api-docs/list-item-text -- 1.79 kB -- -1 B
/api-docs/list-item -- 2.25 kB -- -1 B
/api-docs/list-subheader -- 1.77 kB -- -1 B
/api-docs/list -- 1.68 kB -- -1 B
/api-docs/menu-item -- 1.74 kB -- -1 B
/api-docs/menu-list -- 1.57 kB -- -1 B
/api-docs/menu -- 2.42 kB -- -1 B
/api-docs/mobile-stepper -- 1.94 kB -- -1 B
/api-docs/modal -- 2.43 kB -- -1 B
/api-docs/native-select -- 2.11 kB -- -1 B
/api-docs/no-ssr -- 1.3 kB -- -1 B
/api-docs/outlined-input -- 2.98 kB -- -1 B
/api-docs/pagination-item -- 1.97 kB -- -1 B
/api-docs/pagination -- 2.24 kB -- -1 B
/api-docs/paper -- 1.87 kB -- -1 B
/api-docs/popper -- 1.92 kB -- -1 B
/api-docs/portal -- 1.34 kB -- -1 B
/api-docs/radio-group -- 1.45 kB -- -1 B
/api-docs/radio -- 2.12 kB -- -1 B
/api-docs/rating -- 2.49 kB -- -1 B
/api-docs/root-ref -- 1.42 kB -- -1 B
/api-docs/scoped-css-baseline -- 1.4 kB -- -1 B
/api-docs/select -- 2.96 kB -- -1 B
/api-docs/skeleton -- 1.87 kB -- -1 B
/api-docs/slide -- 1.54 kB -- -1 B
/api-docs/slider -- 3.11 kB -- -1 B
/api-docs/snackbar-content -- 1.61 kB -- -1 B
/api-docs/snackbar -- 2.71 kB -- -1 B
/api-docs/speed-dial-action -- 2.04 kB -- -1 B
/api-docs/speed-dial-icon -- 1.55 kB -- -1 B
/api-docs/speed-dial -- 2.32 kB -- -1 B
/api-docs/step-button -- 1.63 kB -- -1 B
/api-docs/step-connector -- 1.54 kB -- -1 B
/api-docs/step-content -- 1.72 kB -- -1 B
/api-docs/step-icon -- 1.57 kB -- -1 B
/api-docs/step-label -- 1.9 kB -- -1 B
/api-docs/step -- 1.64 kB -- -1 B
/api-docs/stepper -- 1.84 kB -- -1 B
/api-docs/svg-icon -- 2.26 kB -- -1 B
/api-docs/swipeable-drawer -- 2.01 kB -- -1 B
/api-docs/switch -- 2.46 kB -- -1 B
/api-docs/tab-context -- 1.08 kB -- -1 B
/api-docs/tab-list -- 1.09 kB -- -1 B
/api-docs/tab-panel -- 1.48 kB -- -1 B
/api-docs/tab-scroll-button -- 1.62 kB -- -1 B
/api-docs/tab -- 1.97 kB -- -1 B
/api-docs/table-body -- 1.47 kB -- -1 B
/api-docs/table-cell -- 2.13 kB -- -1 B
/api-docs/table-container -- 1.48 kB -- -1 B
/api-docs/table-footer -- 1.47 kB -- -1 B
/api-docs/table-head -- 1.46 kB -- -1 B
/api-docs/table-pagination -- 2.47 kB -- -1 B
/api-docs/table-row -- 1.69 kB -- -1 B
/api-docs/table-sort-label -- 1.83 kB -- -1 B
/api-docs/table -- 1.7 kB -- -1 B
/api-docs/tabs -- 2.68 kB -- -1 B
/api-docs/text-field -- 3.18 kB -- -1 B
/api-docs/textarea-autosize -- 1.13 kB -- -1 B
/api-docs/timeline-connector -- 1.4 kB -- -1 B
/api-docs/timeline-content -- 1.43 kB -- -1 B
/api-docs/timeline-dot -- 1.63 kB -- -1 B
/api-docs/timeline-item -- 1.54 kB -- -1 B
/api-docs/timeline-opposite-content -- 1.44 kB -- -1 B
/api-docs/timeline-separator -- 1.4 kB -- -1 B
/api-docs/timeline -- 1.52 kB -- -1 B
/api-docs/toggle-button-group -- 1.92 kB -- -1 B
/api-docs/toggle-button -- 1.79 kB -- -1 B
/api-docs/toolbar -- 1.65 kB -- -1 B
/api-docs/tooltip -- 2.57 kB -- -1 B
/api-docs/tree-item -- 1.89 kB -- -1 B
/api-docs/tree-view -- 1.92 kB -- -1 B
/api-docs/typography -- 2.59 kB -- -1 B
/api-docs/unstable-trap-focus -- 1.46 kB -- -1 B
/api-docs/zoom -- 1.52 kB -- -1 B
/blog/2019-developer-survey-results -- 6.36 kB -- -1 B
/blog/2019 -- 4.25 kB -- -1 B
/blog/2020-developer-survey-results -- 8.3 kB -- -1 B
/blog/2020-introducing-sketch -- 3.52 kB -- -1 B
/blog/2020-q1-update -- 4.34 kB -- -1 B
/blog/2020-q2-update -- 4.4 kB -- -1 B
/blog/april-2019-update -- 3.14 kB -- -1 B
/blog/august-2019-update -- 2.25 kB -- -1 B
/blog/december-2019-update -- 2.38 kB -- -1 B
/blog/july-2019-update -- 2.14 kB -- -1 B
/blog/june-2019-update -- 2.01 kB -- -1 B
/blog/march-2019-update -- 2.54 kB -- -1 B
/blog/material-ui-v1-is-out -- 6.67 kB -- -1 B
/blog/material-ui-v4-is-out -- 9.69 kB -- -1 B
/blog/may-2019-update -- 2.36 kB -- -1 B
/blog/november-2019-update -- 2.76 kB -- -1 B
/blog/october-2019-update -- 2.51 kB -- -1 B
/blog/september-2019-update -- 2.69 kB -- -1 B
/company/about -- 1.75 kB -- -1 B
/company/contact -- 1.34 kB -- -1 B
/company/jobs -- 1.34 kB -- -1 B
/company/software-engineer -- 5.34 kB -- -1 B
/components/about-the-lab -- 10.3 kB -- -1 B
/components/accordion -- 21.8 kB -- -1 B
/components/alert -- 13.9 kB -- -1 B
/components/app-bar -- 30.1 kB -- -1 B
/components/autocomplete -- 111 kB -- -1 B
/components/avatars -- 9.58 kB -- -1 B
/components/backdrop -- 3.06 kB -- -1 B
/components/badges -- 15.4 kB -- -1 B
/components/bottom-navigation -- 6.14 kB -- -1 B
/components/box -- 8.33 kB -- -1 B
/components/breadcrumbs -- 14.5 kB -- -1 B
/components/buttons -- 26.9 kB -- -1 B
/components/cards -- 17.3 kB -- -1 B
/components/checkboxes -- 16.4 kB -- -1 B
/components/chips -- 21.7 kB -- -1 B
/components/click-away-listener -- 5.5 kB -- -1 B
/components/container -- 3.95 kB -- -1 B
/components/css-baseline -- 7.09 kB -- -1 B
/components/dialogs -- 42.9 kB -- -1 B
/components/dividers -- 12.6 kB -- -1 B
/components/drawers -- 31.1 kB -- -1 B
/components/floating-action-button -- 10.8 kB -- -1 B
/components/grid-list -- 11.8 kB -- -1 B
/components/grid -- 31.8 kB -- -1 B
/components/hidden -- 10.3 kB -- -1 B
/components/icons -- 27.7 kB -- -1 B
/components/links -- 7.2 kB -- -1 B
/components/lists -- 25.9 kB -- -1 B
/components/material-icons -- 729 kB -- -1 B
/components/menus -- 24.2 kB -- -1 B
/components/modal -- 12 kB -- -1 B
/components/no-ssr -- 5.49 kB -- -1 B
/components/pagination -- 8.06 kB -- -1 B
/components/paper -- 3.43 kB -- -1 B
/components/pickers -- 39.1 kB -- -1 B
/components/popover -- 17.4 kB -- -1 B
/components/popper -- 22.6 kB -- -1 B
/components/portal -- 3.25 kB -- -1 B
/components/progress -- 19.2 kB -- -1 B
/components/radio-buttons -- 15.2 kB -- -1 B
/components/rating -- 10.7 kB -- -1 B
/components/selects -- 32.5 kB -- -1 B
/components/skeleton -- 13.9 kB -- -1 B
/components/slider -- 16.2 kB -- -1 B
/components/snackbars -- 22.4 kB -- -1 B
/components/speed-dial -- 14.6 kB -- -1 B
/components/steppers -- 36.6 kB -- -1 B
/components/switches -- 16.7 kB -- -1 B
/components/tables -- 173 kB -- -1 B
/components/tabs -- 24.7 kB -- -1 B
/components/text-fields -- 55.7 kB -- -1 B
/components/textarea-autosize -- 2.95 kB -- -1 B
/components/timeline -- 7.48 kB -- -1 B
/components/toggle-button -- 11.6 kB -- -1 B
/components/tooltips -- 17.9 kB -- -1 B
/components/transitions -- 12.1 kB -- -1 B
/components/tree-view -- 11.5 kB -- -1 B
/components/typography -- 9.85 kB -- -1 B
/components/use-media-query -- 13.6 kB -- -1 B
/customization/breakpoints -- 17.1 kB -- -1 B
/customization/color -- 19.1 kB -- -1 B
/customization/components -- 36.5 kB -- -1 B
/customization/default-theme -- 8.81 kB -- -1 B
/customization/density -- 10.2 kB -- -1 B
/customization/globals -- 5.14 kB -- -1 B
/customization/palette -- 15.1 kB -- -1 B
/customization/spacing -- 2.87 kB -- -1 B
/customization/theming -- 19.3 kB -- -1 B
/customization/typography -- 13.4 kB -- -1 B
/customization/z-index -- 3.5 kB -- -1 B
/discover-more/backers -- 3.04 kB -- -1 B
/discover-more/changelog -- 1.39 kB -- -1 B
/discover-more/languages -- 3.41 kB -- -1 B
/discover-more/related-projects -- 10.3 kB -- -1 B
/discover-more/roadmap -- 3.72 kB -- -1 B
/discover-more/showcase -- 15.2 kB -- -1 B
/discover-more/team -- 7.01 kB -- -1 B
/discover-more/vision -- 6.71 kB -- -1 B
/getting-started/example-projects -- 7.15 kB -- -1 B
/getting-started/faq -- 36.9 kB -- -1 B
/getting-started/installation -- 7.62 kB -- -1 B
/getting-started/learn -- 8.32 kB -- -1 B
/getting-started/support -- 11.1 kB -- -1 B
/getting-started/supported-components -- 7.74 kB -- -1 B
/getting-started/supported-platforms -- 5.93 kB -- -1 B
/getting-started/templates -- 8.77 kB -- -1 B
/getting-started/templates/album -- 5.57 kB -- -1 B
/getting-started/templates/checkout -- 10.2 kB -- -1 B
/getting-started/templates/dashboard -- 8.86 kB -- -1 B
/getting-started/templates/sign-in -- 8.45 kB -- -1 B
/getting-started/templates/sign-up -- 8.55 kB -- -1 B
/getting-started/templates/sticky-footer -- 1.54 kB -- -1 B
/getting-started/usage -- 9.31 kB -- -1 B
/guides/api -- 14.7 kB -- -1 B
/guides/composition -- 15.6 kB -- -1 B
/guides/flow -- 2.34 kB -- -1 B
/guides/interoperability -- 15.6 kB -- -1 B
/guides/localization -- 18.6 kB -- -1 B
/guides/migration-v0x -- 7.78 kB -- -1 B
/guides/migration-v3 -- 18 kB -- -1 B
/guides/minimizing-bundle-size -- 12.2 kB -- -1 B
/guides/responsive-ui -- 4.22 kB -- -1 B
/guides/right-to-left -- 5.36 kB -- -1 B
/guides/server-rendering -- 8.31 kB -- -1 B
/guides/testing -- 8.15 kB -- -1 B
/guides/typescript -- 15.6 kB -- -1 B
/performance/table-component -- 1.44 kB -- -1 B
/performance/table-emotion -- 8.49 kB -- -1 B
/performance/table-hook -- 2.24 kB -- -1 B
/performance/table-mui -- 4.5 kB -- -1 B
/performance/table-raw -- 613 B -- -1 B
/performance/table-styled-components -- 2.6 kB -- -1 B
/premium-themes/onepirate -- 7.34 kB -- -1 B
/premium-themes/onepirate/forgot-password -- 1.01 kB -- -1 B
/premium-themes/onepirate/privacy -- 4.44 kB -- -1 B
/premium-themes/onepirate/sign-in -- 1.07 kB -- -1 B
/premium-themes/onepirate/sign-up -- 1.12 kB -- -1 B
/premium-themes/onepirate/terms -- 11.8 kB -- -1 B
/premium-themes/paperbase -- 7.68 kB -- -1 B
/production-error -- 3.71 kB -- -1 B
/styles/advanced -- 32.2 kB -- -1 B
/styles/api -- 16.4 kB -- -1 B
/styles/basics -- 15.7 kB -- -1 B
/system/api -- 3.57 kB -- -1 B
/system/basics -- 27 kB -- -1 B
/system/borders -- 3.71 kB -- -1 B
/system/display -- 6.19 kB -- -1 B
/system/flexbox -- 5.39 kB -- -1 B
/system/positions -- 2.27 kB -- -1 B
/system/shadows -- 3.69 kB -- -1 B
/system/sizing -- 3.35 kB -- -1 B
/system/spacing -- 5.66 kB -- -1 B
/system/typography -- 3.99 kB -- -1 B
/versions -- 22.8 kB -- -1 B
docs:chunk:shared -- 65.8 kB -- -1 B
docs:shared:chunk/commons -- 5.99 kB -- -1 B
docs:shared:chunk/framework -- 42.3 kB -- -1 B
docs:shared:runtime/main -- 6.78 kB -- -1 B
docs:shared:runtime/webpack -- 1.24 kB -- -1 B
bundle Size Change Size Gzip Change Gzip
Select ▲ +19 B (+0.02% ) 121 kB ▲ +10 B (+0.03% ) 36.1 kB
@material-ui/core ▲ +18 B (0.00% ) 376 kB ▲ +18 B (+0.02% ) 102 kB
TextField ▲ +18 B (+0.01% ) 130 kB ▲ +11 B (+0.03% ) 38.2 kB
Menu ▲ +18 B (+0.02% ) 94 kB ▲ +9 B (+0.03% ) 28.9 kB
TablePagination ▲ +18 B (+0.01% ) 148 kB ▲ +7 B (+0.02% ) 43.6 kB
packages/material-ui/material-ui.production.min.js ▲ +18 B (+0.01% ) 331 kB ▲ +5 B (+0.01% ) 95.5 kB
Autocomplete ▲ +1 B (0.00% ) 136 kB ▼ -3 B (-0.01% ) 42.8 kB
FormHelperText ▲ +1 B (0.00% ) 67.8 kB ▼ -1 B (-0.00% ) 21 kB
FormLabel ▲ +1 B (0.00% ) 68 kB ▲ +1 B (0.00% ) 21 kB
List ▲ +1 B (0.00% ) 66.8 kB ▼ -1 B (-0.00% ) 20.8 kB
ListItem ▲ +1 B (0.00% ) 81.1 kB ▼ -1 B (-0.00% ) 25.4 kB
OutlinedInput ▲ +1 B (0.00% ) 79.1 kB ▲ +1 B (0.00% ) 24.5 kB
Pagination ▲ +1 B (0.00% ) 88.6 kB ▲ +1 B (0.00% ) 27.3 kB
RadioGroup ▲ +1 B (0.00% ) 68.4 kB ▼ -1 B (-0.00% ) 21.2 kB
StepLabel ▲ +1 B (0.00% ) 73 kB ▼ -1 B (-0.00% ) 22.6 kB
TabScrollButton ▲ +1 B (0.00% ) 81.1 kB ▼ -1 B (-0.00% ) 25.4 kB
Avatar ▲ +1 B (0.00% ) 69.7 kB -- 21.8 kB
Backdrop ▲ +1 B (0.00% ) 73.1 kB -- 22.6 kB
Button ▲ +1 B (0.00% ) 83.8 kB -- 25.7 kB
Chip ▲ +1 B (0.00% ) 86.8 kB -- 26.6 kB
Fab ▲ +1 B (0.00% ) 80.9 kB -- 25.2 kB
FilledInput ▲ +1 B (0.00% ) 78 kB -- 24.2 kB
FormControl ▲ +1 B (0.00% ) 68.9 kB -- 21.4 kB
InputLabel ▲ +1 B (0.00% ) 69.8 kB -- 21.5 kB
MenuList ▲ +1 B (0.00% ) 70.5 kB -- 22 kB
PaginationItem ▲ +1 B (0.00% ) 85 kB -- 26.2 kB
Popover ▲ +1 B (0.00% ) 88.3 kB -- 27.3 kB
StepIcon ▲ +1 B (0.00% ) 69.1 kB -- 21.5 kB
Tabs ▲ +1 B (0.00% ) 90.2 kB -- 28.2 kB
Tooltip ▲ +1 B (0.00% ) 107 kB -- 33.9 kB
ListSubheader -- 67.3 kB ▼ -5 B (-0.02% ) 21.1 kB
@material-ui/system -- 17.2 kB ▼ -2 B (-0.04% ) 4.51 kB
Box -- 73.3 kB ▼ -2 B (-0.01% ) 22.2 kB
ClickAwayListener -- 4.13 kB ▼ -2 B (-0.12% ) 1.66 kB
ExpansionPanel -- 77.2 kB ▼ -2 B (-0.01% ) 24.2 kB
ExpansionPanelSummary -- 82.2 kB ▼ -2 B (-0.01% ) 26 kB
Stepper -- 69.2 kB ▼ -2 B (-0.01% ) 21.8 kB
TabContext -- 2.65 kB ▲ +2 B (+0.17% ) 1.15 kB
TabList -- 91.4 kB ▲ +2 B (+0.01% ) 29.2 kB
@material-ui/lab -- 223 kB ▼ -1 B (-0.00% ) 65.6 kB
@material-ui/styles -- 52.1 kB ▼ -1 B (-0.01% ) 15.6 kB
AccordionSummary -- 82.2 kB ▼ -1 B (-0.00% ) 26 kB
CssBaseline -- 66.4 kB ▼ -1 B (-0.00% ) 20.8 kB
FormGroup -- 66.4 kB ▲ +1 B (0.00% ) 20.8 kB
Hidden -- 70.5 kB ▼ -1 B (-0.00% ) 22.1 kB
LinearProgress -- 69.9 kB ▼ -1 B (-0.00% ) 21.8 kB
MobileStepper -- 72.4 kB ▲ +1 B (0.00% ) 22.6 kB
NoSsr -- 2.18 kB ▼ -1 B (-0.10% ) 1.03 kB
Radio -- 87.3 kB ▲ +1 B (0.00% ) 27.6 kB
ScopedCssBaseline -- 67.3 kB ▼ -1 B (-0.00% ) 21.1 kB
Slide -- 30.7 kB ▲ +1 B (+0.01% ) 10.3 kB
Snackbar -- 80.9 kB ▼ -1 B (-0.00% ) 25.4 kB
SnackbarContent -- 68 kB ▲ +1 B (0.00% ) 21.3 kB
SpeedDial -- 91.1 kB ▲ +1 B (0.00% ) 28.9 kB
StepButton -- 86.4 kB ▼ -1 B (-0.00% ) 27.2 kB
StepConnector -- 67.2 kB ▼ -1 B (-0.00% ) 21.1 kB
TableCell -- 68.6 kB ▼ -1 B (-0.00% ) 21.5 kB
TreeItem -- 80.5 kB ▼ -1 B (-0.00% ) 25.5 kB
useAutocomplete -- 14.7 kB ▲ +1 B (+0.02% ) 5.27 kB
useMediaQuery -- 2.56 kB ▲ +1 B (+0.09% ) 1.06 kB
Zoom -- 29 kB ▲ +1 B (+0.01% ) 9.8 kB
@material-ui/utils -- 7.19 kB -- 2.61 kB
Accordion -- 77.2 kB -- 24.2 kB
AccordionActions -- 66.5 kB -- 20.8 kB
AccordionDetails -- 66.4 kB -- 20.7 kB
Alert -- 87.4 kB -- 27.5 kB
AlertTitle -- 68.7 kB -- 21.5 kB
AppBar -- 68.5 kB -- 21.4 kB
AvatarGroup -- 70.7 kB -- 22.4 kB
Badge -- 71.3 kB -- 21.8 kB
BottomNavigation -- 66.8 kB -- 20.9 kB
BottomNavigationAction -- 79.6 kB -- 25.2 kB
Breadcrumbs -- 84.6 kB -- 26.7 kB
ButtonBase -- 78 kB -- 24.5 kB
ButtonGroup -- 87.5 kB -- 27 kB
Card -- 67.3 kB -- 21 kB
CardActionArea -- 79.1 kB -- 25 kB
CardActions -- 66.5 kB -- 20.8 kB
CardContent -- 66.4 kB -- 20.7 kB
CardHeader -- 69.6 kB -- 21.8 kB
CardMedia -- 66.8 kB -- 20.9 kB
Checkbox -- 86.3 kB -- 27.4 kB
CircularProgress -- 68.6 kB -- 21.5 kB
Collapse -- 73.5 kB -- 22.7 kB
colorManipulator -- 4.14 kB -- 1.63 kB
Container -- 67.7 kB -- 21.1 kB
Dialog -- 88.4 kB -- 27.6 kB
DialogActions -- 66.5 kB -- 20.8 kB
DialogContent -- 66.7 kB -- 20.8 kB
DialogContentText -- 68.5 kB -- 21.5 kB
DialogTitle -- 68.8 kB -- 21.6 kB
Divider -- 67.1 kB -- 21.1 kB
docs:/ -- 12.4 kB -- -1 B
docs:/_app -- 35.8 kB -- -1 B
Drawer -- 90.4 kB -- 27.5 kB
ExpansionPanelActions -- 66.5 kB -- 20.8 kB
ExpansionPanelDetails -- 66.4 kB -- 20.7 kB
Fade -- 28.9 kB -- 9.66 kB
FormControlLabel -- 70 kB -- 21.9 kB
Grid -- 69.5 kB -- 21.8 kB
GridList -- 66.9 kB -- 21 kB
GridListTile -- 68.2 kB -- 21.3 kB
GridListTileBar -- 67.7 kB -- 21.2 kB
Grow -- 29.5 kB -- 9.88 kB
Icon -- 67.3 kB -- 21 kB
IconButton -- 80.2 kB -- 25.1 kB
Input -- 76.9 kB -- 24 kB
InputAdornment -- 69.6 kB -- 21.9 kB
InputBase -- 75 kB -- 23.5 kB
Link -- 71.1 kB -- 22.4 kB
ListItemAvatar -- 66.5 kB -- 20.8 kB
ListItemIcon -- 66.6 kB -- 20.8 kB
ListItemSecondaryAction -- 66.4 kB -- 20.8 kB
ListItemText -- 69.5 kB -- 21.8 kB
MenuItem -- 82.2 kB -- 25.7 kB
Modal -- 15.1 kB -- 5.27 kB
NativeSelect -- 81.4 kB -- 25.6 kB
Paper -- 66.8 kB -- 20.8 kB
Popper -- 28.7 kB -- 10.3 kB
Portal -- 2.87 kB -- 1.29 kB
Rating -- 75.3 kB -- 24.2 kB
RootRef -- 4.64 kB -- 1.76 kB
Skeleton -- 67.7 kB -- 21.3 kB
Slider -- 80.4 kB -- 25.5 kB
SpeedDialAction -- 123 kB -- 39.1 kB
SpeedDialIcon -- 69 kB -- 21.6 kB
Step -- 67.2 kB -- 21.1 kB
StepContent -- 74.7 kB -- 23.3 kB
styles/createMuiTheme -- 21.9 kB -- 7.57 kB
SvgIcon -- 67.5 kB -- 21 kB
SwipeableDrawer -- 97.8 kB -- 30.7 kB
Switch -- 85.5 kB -- 26.8 kB
Tab -- 80.6 kB -- 25.6 kB
Table -- 67 kB -- 21 kB
TableBody -- 66.6 kB -- 20.8 kB
TableContainer -- 66.4 kB -- 20.7 kB
TableFooter -- 66.6 kB -- 20.8 kB
TableHead -- 66.6 kB -- 20.8 kB
TableRow -- 67 kB -- 21 kB
TableSortLabel -- 81.5 kB -- 25.7 kB
TabPanel -- 67.3 kB -- 21 kB
TextareaAutosize -- 5.23 kB -- 2.19 kB
Timeline -- 66.9 kB -- 20.9 kB
TimelineConnector -- 66.4 kB -- 20.8 kB
TimelineContent -- 66.9 kB -- 20.9 kB
TimelineDot -- 67.5 kB -- 21.1 kB
TimelineItem -- 67.6 kB -- 21.1 kB
TimelineOppositeContent -- 67 kB -- 20.9 kB
TimelineSeparator -- 66.4 kB -- 20.8 kB
ToggleButton -- 80.2 kB -- 25.4 kB
ToggleButtonGroup -- 67.8 kB -- 21.3 kB
Toolbar -- 66.8 kB -- 20.9 kB
TreeView -- 72.8 kB -- 22.8 kB
Typography -- 68.1 kB -- 21.2 kB
Unstable_TrapFocus -- 3.85 kB -- 1.59 kB
useScrollTrigger -- 2.66 kB -- 1.08 kB

Generated by 🚫 dangerJS against 9d64fe3

@mbrookes mbrookes requested a review from eps1lon August 14, 2020 18:16
eps1lon
eps1lon reviewed Aug 15, 2020
View reviewed changes
packages/material-ui/src/Popover/Popover.test.js Outdated
'Popover',
);

// expect(console.error.callCount).to.equal(1);
Copy link
Member

@eps1lon eps1lon Aug 15, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess there are other prop types warnings beside the deprecation warning? The Popover might have required props. Saw this in another PR of you as well so this might be the same issue.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Popover might have required props.

That makes sense, thanks.

Saw this in another PR of [yours] as well

Yeah, copy-pasta. Fixed, thanks.

@oliviertassinari oliviertassinari merged commit c360619 into mui:master Aug 15, 2020
@mbrookes mbrookes deleted the popover-deprecate-onX-props branch August 15, 2020 21:19
@oliviertassinari oliviertassinari mentioned this pull request Sep 15, 2020
Closed
42 tasks
@mbrookes mbrookes mentioned this pull request Sep 23, 2020
Closed
oliviertassinari added a commit that referenced this pull request Nov 24, 2020
@oliviertassinari
Revert "[Popover] Deprecate transition onX props (#22202)"
f773cef 
This reverts commit c360619.
oliviertassinari pushed a commit that referenced this pull request Nov 24, 2020
@mbrookes @oliviertassinari
[Popover] Deprecate transition onX props (#22202)
0e15313
oliviertassinari pushed a commit that referenced this pull request Nov 24, 2020
@mbrookes @oliviertassinari
[Popover] Deprecate transition onX props (#22202)
7edaadc
oliviertassinari pushed a commit that referenced this pull request Jan 24, 2021
@mbrookes @oliviertassinari
[Popover] Deprecate transition onX props (#22202)
764d7e4
oliviertassinari pushed a commit that referenced this pull request Jan 25, 2021
@mbrookes @oliviertassinari
[Popover] Deprecate transition onX props (#22202)
8028cb8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon left review comments

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
component: Popover The React component. deprecation New deprecation message
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mbrookes @mui-pr-bot @oliviertassinari @eps1lon