-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Stepper] Remove Paper and built-in padding #22564
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that with the change, we can use the default outlined container for the demos, instead of the grey background.
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mobile stepper still has a white background, it's easier to spot with:
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
ab80930
to
9450523
Compare
@oliviertassinari I've tweaked the Button layout and variant for the first demo to better match the original component: Spec: Once it's good, I'll do the rest of the demos. |
@mbrookes Looks better 👍 |
Follow 'Stepper Feedback' example at https://material.io/archive/guidelines/components/steppers.html#steppers-types-of-steppers
9450523
to
32f150f
Compare
@mbrookes I think that option 1 is better. It will make the source of the demo simpler. Also, I don't think that the stepper should have any padding. |
Oh right, one breaking change at the time, removal of padding could be the very next one 👼.
A couple of thoughts:
|
288253f
to
baedb2b
Compare
baedb2b
to
86fb915
Compare
We had a power cut this afternoon, but have been working offline on simplifying the demos. It seems I've already hit on several of the things you suggested. Take a look.
That's down to the demo not having a container. You can't have it both ways. 😄
I think we need to show a functioning Stepper first.
Most of the demos are now simplified.
Already done.
Already simpler, but I'll take another look.
Already done in "Mk 3".
Already done. |
35e5337
to
ec5f8e6
Compare
ec5f8e6
to
09a3cf2
Compare
Breaking changes
<div>
. Stepper no longer has elevation, nor inherits Paper's props.Closes #18423