-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Modal][Dialog] Deprecate duplicate props with onChange #24081
Merged
oliviertassinari
merged 1 commit into
mui:v4-deprecations
from
oliviertassinari:modal-deprecate-disable-props
Dec 23, 2020
Merged
[Modal][Dialog] Deprecate duplicate props with onChange #24081
oliviertassinari
merged 1 commit into
mui:v4-deprecations
from
oliviertassinari:modal-deprecate-disable-props
Dec 23, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
component: dialog
This is the name of the generic UI component, not the React module!
component: modal
This is the name of the generic UI component, not the React module!
deprecation
New deprecation message
labels
Dec 20, 2020
@material-ui/core: parsed: +Infinity% , gzip: +Infinity% Details of bundle changes.Comparing: ff6462b...aaa7f98 Details of page changes
|
oliviertassinari
force-pushed
the
modal-deprecate-disable-props
branch
from
December 20, 2020 19:27
c178e7b
to
37b0334
Compare
42 tasks
mnajdova
reviewed
Dec 22, 2020
mnajdova
reviewed
Dec 22, 2020
github-actions
bot
added
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Dec 22, 2020
oliviertassinari
force-pushed
the
modal-deprecate-disable-props
branch
from
December 22, 2020 14:35
37b0334
to
aaa7f98
Compare
github-actions
bot
removed
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Dec 22, 2020
mnajdova
approved these changes
Dec 22, 2020
oliviertassinari
added a commit
that referenced
this pull request
Jan 24, 2021
oliviertassinari
added a commit
that referenced
this pull request
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: dialog
This is the name of the generic UI component, not the React module!
component: modal
This is the name of the generic UI component, not the React module!
deprecation
New deprecation message
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add deprecation for #23607 and #23571