Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accordion] Implement Accordion #25

Closed
Tracked by #10
michaldudak opened this issue Jul 19, 2023 · 5 comments · Fixed by #577
Closed
Tracked by #10

[Accordion] Implement Accordion #25

michaldudak opened this issue Jul 19, 2023 · 5 comments · Fixed by #577
Assignees
Labels
component: accordion This is the name of the generic UI component, not the React module! new feature New feature or request

Comments

@michaldudak
Copy link
Member

michaldudak commented Jul 19, 2023

This is the place to gather ideas, measure interest and discuss the API and implementation details of the accordion component and hook.

See #10 for the umbrella issue to track progress on Base UI and mui/material-ui#6218 for the problem this project solve.

@michaldudak michaldudak changed the title Accordion ⭐ [Accordion][base] Create the unstyled component and hook Jul 19, 2023
@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 14, 2023

Material UI id API feels so outdated (e.g. id={summary.props['aria-controls']}) now that we can use the context and useId https://mui.com/material-ui/react-accordion/#basic-accordion

Screenshot 2023-08-15 at 00 52 48

@oliviertassinari
Copy link
Member

To consider what we should do with the arrow key navigation https://www.w3.org/WAI/ARIA/apg/patterns/accordion/#keyboardinteraction. I don't know if we want this, I guess, why not?

@michaldudak michaldudak changed the title [Accordion][base] Create the unstyled component and hook [Accordion][base-ui] Create the unstyled component and hook Aug 18, 2023
@logonoff
Copy link

an idea for the base-ui accordion component is to use the details and summary HTML elements for the component so that the accordion would still work for users who have javascript turned off. i feel like semantically it might also make more sense since its functionality is similar to the accordion component

@michaldudak
Copy link
Member Author

Related issue to take into consideration: mui/material-ui#36297

@michaldudak michaldudak transferred this issue from mui/material-ui Feb 27, 2024
@michaldudak michaldudak changed the title [Accordion][base-ui] Create the unstyled component and hook [Accordion] Create the unstyled component and hook Feb 27, 2024
@michaldudak michaldudak added new feature New feature or request component: accordion This is the name of the generic UI component, not the React module! labels Feb 27, 2024
@colmtuite colmtuite changed the title [Accordion] Create the unstyled component and hook [Accordion] Implement Accordion Mar 21, 2024
@colmtuite colmtuite assigned michaldudak and unassigned michaldudak Mar 21, 2024
@mj12albert mj12albert self-assigned this Jul 10, 2024
@oliviertassinari oliviertassinari changed the title [Accordion] Implement Accordion [accordion] Implement Accordion Oct 3, 2024
Copy link

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

@michaldudak michaldudak changed the title [accordion] Implement Accordion [Accordion] Implement Accordion Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: accordion This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
Status: Done
4 participants