Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[code-infra] Clean-up warnOnce duplication #615

Open
oliviertassinari opened this issue Sep 8, 2024 · 0 comments
Open

[code-infra] Clean-up warnOnce duplication #615

oliviertassinari opened this issue Sep 8, 2024 · 0 comments
Labels
core Infrastructure work going on behind the scenes performance scope: code-infra Specific to the code-infra product

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 8, 2024 •
edited by github-actions bot
Loading

Problem

The warnOnce logic is duplicated all over the place in the MUI codebase:

Context

I initially worked on this because of mui/mui-x#13911. This looks like a perfect helper for @base-ui/internals per https://www.notion.so/mui-org/engineering-mui-utils-purpose-9a9fc9da3a004864b6c4e1f4d1f24f95.

Search keywords:
@oliviertassinari oliviertassinari added scope: code-infra Specific to the code-infra product core Infrastructure work going on behind the scenes labels Sep 8, 2024
This was referenced Sep 8, 2024
Merged
Merged
@oliviertassinari oliviertassinari changed the title [code-infra] Clean-up warnOnce logic [code-infra] Clean-up warnOnce duplication Sep 13, 2024
@oliviertassinari oliviertassinari transferred this issue from mui/mui-public Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes performance scope: code-infra Specific to the code-infra product
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oliviertassinari