[Progress][RadioGroup][Tabs] Unify text direction (LTR/RTL) handling #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy preview |
mj12albert
added
component: tabs
mj12albert
force-pushed
the
feat/standardize-rtl
branch
10 times, most recently
from
d0ddf3a
to
7f46330
Compare
mj12albert
commented
Nov 28, 2024
| @@ -94,6 +92,7 @@ const TabsList = React.forwardRef(function TabsList( | |||
| highlightedIndex={highlightedTabIndex} | |||
| enableHomeAndEndKeys | |||
| loop={loop} | |||
| orientation={orientation} | |||
There was a problem hiding this comment.
Forgot this in #751
For Tabs, the cross-orientation arrow key should be ignored (and scroll the page if applicable)
mj12albert
requested review from
atomiks,
colmtuite and
michaldudak
as code owners
mj12albert
requested review from
michaldudak
and removed request for
michaldudak and
colmtuite
mj12albert
force-pushed
the
feat/standardize-rtl
branch
from
ac53f82
to
3adec4e
Compare
michaldudak
approved these changes
Nov 28, 2024
| Uploading files | ||
| </span> | ||
| <Progress.Track className={classes.track}> | ||
| <Progress.Indicator className={classes.indicator} /> |
There was a problem hiding this comment.
This demo looks broken on CodeSandbox (the progress bar is invisible). Could you please check?
There was a problem hiding this comment.
Looks like the CSS color vars I was using from various theme.css got lost because theme.css isn't linked correctly by the index.html in the sandbox
I'll put fallback values for the stylesheet touched in this PR: bdee765#diff-2e7b61a5d5509e7a87e5c596b9db8313ed2ea6d2c1b5decf0c161a49e776e6cd
There was a problem hiding this comment.
#894 FYI @michaldudak
mj12albert
force-pushed
the
feat/standardize-rtl
branch
from
986b44f
to
19f646c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #831
Tabs/RadioGroupautomatically workProgress.Indicator's build-in styles changed from usingleft: 0/right: 0toinset-inline-start: 0, there should be no browser support issue (reference)I have followed (at least) the PR section of the contributing guide.