Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transition forwardRef logic issue #2035

Closed
2 tasks done
oliviertassinari opened this issue Jul 25, 2020 · 1 comment
Closed
2 tasks done

Transition forwardRef logic issue #2035

oliviertassinari opened this issue Jul 25, 2020 · 1 comment
Assignees
@eps1lon
Labels
bug 🐛 Something isn't working

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 25, 2020 •
edited
Loading

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

Crash

Expected Behavior 🤔

Shouldn't crash

Steps to Reproduce 🕹

Steps:

  1. Open https://codesandbox.io/s/elegant-black-f6fgv?file=/src/App.jsx.
  2. Open the picker

Context 🔦

I was looking into mui/material-ui#21873 (comment).

See mui/material-ui#21858 for a prior-art. This originates from a wrong forward ref logic here. We have added a new warning in v5.0.0-alpha.5 to help identify the origin.

Your Environment 🌎

Tech Version
@material-ui/core v5.0.0-alpha.4
@material-ui/pickers v4.0.0-alpha.10
@oliviertassinari oliviertassinari added the bug 🐛 Something isn't working label Jul 25, 2020
@eps1lon eps1lon self-assigned this Jul 31, 2020
@eps1lon
Copy link
Member

eps1lon commented Aug 1, 2020

Fixed in #2053

@eps1lon eps1lon closed this as completed Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eps1lon eps1lon

Labels
bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oliviertassinari @eps1lon