Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warnings from MUI > 4.12.X #2200

Closed
2 tasks done
MoritzHorch opened this issue Jul 8, 2021 · 2 comments
Closed
2 tasks done

Fix deprecation warnings from MUI > 4.12.X #2200

MoritzHorch opened this issue Jul 8, 2021 · 2 comments
Labels
wontfix This will not be worked on in the short/medium term

Comments

@MoritzHorch
Copy link

MoritzHorch commented Jul 8, 2021

In Material-UI 4.12.X several styling deprecations errors were introduced. Especially the fade color utility which is used many times in this project. Now I know that active development has been moved to Material-UI V5, but I think we should at least have fixes for such console-spamming errors as long as Material-UI V5 is still not a stable release and especially when the new pickers are only a part of the lab.

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

When using and opening DatePicker in combination with the MuiPickersUtilsProvider the following error will be logged to the console:

Material-UI: The fadecolor utility was renamed toalpha` to better describe its functionality.

You should use import { alpha } from '@material-ui/core/styles' at ... at MuiPickersUtilsProvider at ...

Or: Warning: Failed prop type: The prop justifyofForwardRef(Grid)is deprecated. UsejustifyContent instead, the prop was renamed.

Expected Behavior 🤔

No deprecation error should be logged and the suggested utilitly / property should be used.

Steps to Reproduce 🕹

Steps:

  1. Open https://codesandbox.io/s/eager-drake-6wqck
  2. Open the pickers one by one
  3. See several deprecation logs arise

Context 🔦

This issue heavily disturbs working with the current stable release and right now we do not feel like that using the beta- and lab channels is the right way to go in production apps.

Your Environment 🌎

"@material-ui/core": "4.12.1",
"@material-ui/pickers": "3.3.10",
"moment": "2.29.1",
"@date-io/moment": "1.x",
"react": "latest",
"react-dom": "latest",
"react-scripts": "latest"

@MoritzHorch MoritzHorch added the status: needs triage These issues haven't been looked at yet by a maintainer. label Jul 8, 2021
@MonstraG
Copy link

MonstraG commented Jul 8, 2021

Same thing here, updated to MUI v4.12.X to simplify migration when v5 finally comes out, hit this.

@oliviertassinari oliviertassinari added wontfix This will not be worked on in the short/medium term and removed status: needs triage These issues haven't been looked at yet by a maintainer. labels Jul 8, 2021
@oliviertassinari
Copy link
Member

We have archived this repository, more details in #2157.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on in the short/medium term
Projects
None yet
Development

No branches or pull requests

3 participants