Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript support #78

Closed
alitaheri opened this issue Nov 25, 2017 · 7 comments
Closed

Typescript support #78

alitaheri opened this issue Nov 25, 2017 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@alitaheri
Copy link
Member

material-ui supports typescript. I think we should do the same. I'm willing to write and maintain the typings. Are you open to the idea? @dmtrKovalenko

@dmtrKovalenko
Copy link
Member

Yes. Really I am intent on support both flow and typescript. But unfortunatly I have really little time now, so the most relevant feature would be 24 hours, that I would work on.
If you wanna create typings for ts - BIG THANKS
Your work would be appreciated.

@alitaheri
Copy link
Member Author

@dmtrKovalenko This is blocked by the deployment method. Since we don't distribute every component like material-ui and instead distribute a bundle of the three main components the typings won't be much of use. We should focus on the build process first and then worry about the typings.

@dmtrKovalenko
Copy link
Member

Ohh, I see. But its just like declarations for the file, it doesnt possible to declare all types in one file?

@alitaheri
Copy link
Member Author

@dmtrKovalenko It is possible, but not really recommended since it becomes hard to maintain. We should first decide on way we wish to deploy the package then write the typings.

@dmtrKovalenko
Copy link
Member

Hmm I`ll take a look on that, I think we should implement that anyway

@KKrisu
Copy link

KKrisu commented Oct 3, 2018

Greetins @alitaheri How is it going, are the typings already available? (I can't find them on npm 🤔 )

@dmtrKovalenko
Copy link
Member

They are provided with the project directly. No need to install @types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants